Devicetree
 help / color / mirror / Atom feed
From: Stefan Wahren <wahrenst@gmx.net>
To: "Kryštof Černý" <cleverline1mc@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Ben Gardner <bgardner@wabtec.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] w1: ds2482: Add regulator support
Date: Mon, 25 Nov 2024 16:49:26 +0100	[thread overview]
Message-ID: <6ea973d8-e625-47fd-a69a-b39c22f2ccc7@gmx.net> (raw)
In-Reply-To: <20241124-ds2482-add-reg-v3-1-806df39c9454@gmail.com>

Hi Kryštof,

> +	ret = devm_regulator_get_enable(&client->dev, "vcc");
> +	if (ret) {
> +		dev_err(&client->dev, "Fail to enable regulator\n");
> +		return ret;
> +	}


I'm fine with using devm_regulator_get_enable() because it doesn't break
existing DTS like imx6ull-tarragon-master, which doesn't have vcc defined.
But please use dev_err_probe() here instead and s/Fail/Failed/ in the
error message.

Best regards


  reply	other threads:[~2024-11-25 15:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-24 16:21 [PATCH v3 0/3] Add support for attaching a regulator to w1: ds2482 Kryštof Černý via B4 Relay
2024-11-24 16:21 ` [PATCH v3 1/3] w1: ds2482: Add regulator support Kryštof Černý via B4 Relay
2024-11-25 15:49   ` Stefan Wahren [this message]
2024-11-24 16:21 ` [PATCH v3 2/3] w1: ds2482: Fix datasheet URL Kryštof Černý via B4 Relay
2024-11-24 16:21 ` [PATCH v3 3/3] dt-bindings: w1: ds2482: Add vcc-supply property Kryštof Černý via B4 Relay
2024-11-25 15:40   ` Stefan Wahren
2024-11-25 22:39     ` Kryštof Černý
2024-11-26  7:42       ` Krzysztof Kozlowski
2024-11-25 18:35   ` [PATCH v3 3/3] dt-bindings: w1: ds2482: Add vcc-supply propertyy Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ea973d8-e625-47fd-a69a-b39c22f2ccc7@gmx.net \
    --to=wahrenst@gmx.net \
    --cc=bgardner@wabtec.com \
    --cc=cleverline1mc@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox