From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 856E7C433EF for ; Tue, 12 Jul 2022 06:47:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229709AbiGLGrU (ORCPT ); Tue, 12 Jul 2022 02:47:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231877AbiGLGrT (ORCPT ); Tue, 12 Jul 2022 02:47:19 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB66265572 for ; Mon, 11 Jul 2022 23:47:15 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id u13so12347923lfn.5 for ; Mon, 11 Jul 2022 23:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=jMuRcrjE7BdyitlsbzjBTLs0XHaQgX+9YW3636oyPpA=; b=rGaxi11FZcV17/AmY/XXSQakC2aoNyn09A4wYTzxBLTuUk6SH4pZMO4LLGabGqoVxa 3SlJ8hsmjq+OoPUJAjPO6JjfoOrfsi79JwY2UcDs3q66EL/LH2EnRqgfn1Zg/jK1cB9i ckRieC3iYDCruJaoCbuIw3bmoEIFDFa0G+Y6s5luIaB0mMHEPXr4KJd7Rcsagz+4LmEk q/PeUa1vCV/uHj98uvIJCx2+t7FnkzXQdrzAZtJu1TQCODz4TlBshN5xUfHApQuG4o5f UYuOFsFb/QqURLQpMP7sjKwA2ZFJFkC9WPyS5n/4QwblS5WfJV2FmUyAcVgE9vIM86fV uR+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=jMuRcrjE7BdyitlsbzjBTLs0XHaQgX+9YW3636oyPpA=; b=1MaEJgoYbMRyL89ItTq9VqInJIo7uB8f/IckbB7MAOMlhIwfZNEj2okTpcrmc8ds+r aJaPFiVBMGTKIuxspUaUZQtI7IchyC2rh/Olo8ggj7mZOUS6GVyza3p4QPnOJ5xJtO4H XPSS+bvS0+Tr8Z+Guv2IxRCZeQlllRcaTkBxAA0zWW+sF5q9vOwaAjRf/I7zRP/6y29m GJFDmyyMCcQZ1rb+u3v9AdPSzcXt3ne+XSDuYxgdx1sYgSsOS0t7j1YNE4KMGlaR2TvR 3tPine3k83YDqd5PXJ8DGuyCMuXg0X5rvbjbGmYneiXjT/wjrne0O+pnuPX+U4yqCX5v 1AYQ== X-Gm-Message-State: AJIora9BIcvZtxE6Qr1GaokiiZqJjmrZsCBRiGbwjeFUlolk0TKiIzKV 5P5HBF+5iiRrFum2KJUci034Iw== X-Google-Smtp-Source: AGRyM1u/RLfflARYY940Xxjm3/t52ojyKVUi1YPU8bjt5W5WTYcRfzbQy2HB2eCLRiMk5r4kkF9oqw== X-Received: by 2002:a05:6512:3b0a:b0:489:da13:180a with SMTP id f10-20020a0565123b0a00b00489da13180amr7313675lfv.489.1657608433934; Mon, 11 Jul 2022 23:47:13 -0700 (PDT) Received: from [10.0.0.8] (fwa5cab-55.bb.online.no. [88.92.171.55]) by smtp.gmail.com with ESMTPSA id l18-20020ac24312000000b004785b0dfba4sm1993959lfh.195.2022.07.11.23.47.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jul 2022 23:47:13 -0700 (PDT) Message-ID: <6ebdb95a-6458-b77e-e14c-e89539c51b3f@linaro.org> Date: Tue, 12 Jul 2022 08:47:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/3] mmc: sdhci-msm: add MSM8998 SDCC specific compatible Content-Language: en-US To: Doug Anderson Cc: Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Adrian Hunter , Bhupesh Sharma , Linux MMC List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , linux-arm-msm References: <20220711082709.39102-1-krzysztof.kozlowski@linaro.org> <20220711082709.39102-2-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/07/2022 17:08, Doug Anderson wrote: > Hi, > > On Mon, Jul 11, 2022 at 1:27 AM Krzysztof Kozlowski > wrote: >> >> Add a MSM8998-specific SDCC compatible, because using only a generic >> qcom,sdhci-msm-v4 fallback is deprecated. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> drivers/mmc/host/sdhci-msm.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c >> index e395411fb6fd..bb169c1c2b5e 100644 >> --- a/drivers/mmc/host/sdhci-msm.c >> +++ b/drivers/mmc/host/sdhci-msm.c >> @@ -2447,6 +2447,7 @@ static const struct of_device_id sdhci_msm_dt_match[] = { >> {.compatible = "qcom,msm8992-sdhci", .data = &sdhci_msm_mci_var}, >> {.compatible = "qcom,msm8994-sdhci", .data = &sdhci_msm_mci_var}, >> {.compatible = "qcom,msm8996-sdhci", .data = &sdhci_msm_mci_var}, >> + {.compatible = "qcom,msm8998-sdhci", .data = &sdhci_msm_mci_var}, > > FWIW I'm _against_ this change. > > In my mind while it is correct to specify both the specific and > generic compatible string in the device tree, the driver itself should > rely on just the generic compatible string until there is a reason to > use the specific one (like we needed to for sdm845 and sc7180). > > I think I pointed that out before, but somehow all of the specific > device tree strings have snuck their way into the driver without me > paying attention. :( I thought it's existing practice for some time, but it's a fresh commit 466614a9765c ("mmc: sdhci-msm: Add SoC specific compatibles"). I agree that it does not make much sense to add each compatible to the driver, so how about reverting 466614a9765c? Best regards, Krzysztof