From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4139F20E329 for ; Fri, 10 Jan 2025 12:43:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736513014; cv=none; b=jQ5uzrjPzYS+KQhPb+C4MZVkGH1eKjSB7D4/hMGOqpbK/nEOKra99aEXh7EYJycvQ8ohk3MB0mlQ1/PCDzvwt725xyRxPPfoOlfYNjQtLAcU3U5scVpzCHu3mUfEwJfYS+adYly8sBbVrz5kyPJK0PzmnIsF6ntwhN/VdI7Z9m0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736513014; c=relaxed/simple; bh=tAcTpS2jRhwp4oIrzGx4utl7zu4BovqbAGhZY9IIQ3k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fD76EICZGTaZbWXJznHXEhED2RlTJ7V3M9OpjFpAVZudVLs7TNlTOCKdLs0uAutzAFKY4hJmR37qciHpNMC9RtfxLHrCdJel4bIFrCzxK0kcSFQcYqycQuefb6I2ftrTxeBZ3C2kUL0CTuiAC1GUh61PnQSC2f4ME/hWNhtSq7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=S2adHXuB; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S2adHXuB" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43637977fa4so2282615e9.3 for ; Fri, 10 Jan 2025 04:43:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736513010; x=1737117810; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Prlary+OMsV7AQL9JJp5WwDtVeDhVejTzPRLWDvQlZM=; b=S2adHXuBLNNTEAGrltoH8AK+Xv3vfmTSVw5wlAUg8EfokpDMmLKI+L4v/rRL9/M3UJ B6Ko7xWld4Ng4hYgZ6luoTdu0YrasoeI+iEquVIoHclqoX3wXG8FLbigELkrJxZiN9au HEw5iSIwjYH8inMVDkKkESw81mIkTujVmRGgskRw347Fp/Mg7fl5uj6aoUHZEamG2MeF P5xeSuUGYhWgj7v+hzv7kZy6Gew8rnGka1cUtQoXBeerhD0D6FFTH/1f74rKXjzkWIpw 2kpZneqneqBfFGP2FAL2+fHvyHaC8uSL/y3okH5uwL2Xe2VkXL0bmWuwaN/Jos6RUcQe FNXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736513010; x=1737117810; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Prlary+OMsV7AQL9JJp5WwDtVeDhVejTzPRLWDvQlZM=; b=fhSa0r63HWrt9pnVmx5OlQ87Ecn9XhOdVAlYXl96PHXxC88PxLICDI1i1uN964Ptmh vuBKBL+60JwWR1qghE8tqJyMyTHpNTmjrtrn4ebi8K2vXu534kB5cqzFLwCWo3QInYO7 MmeFggfCM5jJOkambF7bl5Im25HR2obUxOLZB8P+REgV0Aizz7LjdrauY42b2YdBJ5h/ dZX5pd6sHfZYv4qrmDMCAFOKkImo1O2JlQiMl1llSyPv6RA38hhPMk2aSnrx7F9IfaXJ +QdGfL7KVShzgFT1eqb8foO5yGpaiepLf5g2DdBCPMcD/G+L2825RV1mMVdZEN9otmy9 mv/g== X-Forwarded-Encrypted: i=1; AJvYcCX2lq9QBOalcwwoHxvwIx+xfxzhFqLmrPFzyPYop2zTogLlrlLI1oSGRkPIQSnE7/GbEz4V/jLx0ppS@vger.kernel.org X-Gm-Message-State: AOJu0YzckKIrL/7vUbQdz2cgdbeHsj1Ys4A7TcGrunWsAxyrKSJJcvnh SM6+/zJLTDgiTvtesE+L8AJg/+Nbq1OOJz/Bc2lePnGWSGZnGLlj/N1iUwl03VE= X-Gm-Gg: ASbGncugykoJ3WQns153GMd35JjgWhNR+FtLaREoSgUVaxSakhjBEem25pkQ7fHy0tT cEvqeKqW0G5yBYJIMT2yMfXBddBn2RLTef/kc75vcB0EYuHIg3so92UGL9IXOOFpm86bdOSMjb9 j4Oa5FLnySCD9BMPPpvp6Qd8QQ3NSKOVN/7ELgfsWofYI+IoCDyX60mKcTsrU2YgCGKAgukGKQq GxeJaXlzaoKbtF0zhjvreicIadwAHKmFCArFPd6QusdxfLKsvDTmEHauGiZ6dx7EXkdAps4UaPB X-Google-Smtp-Source: AGHT+IH+h6+u4V0VlF0HY+8A/du6CsQn4tLW/yS6+DMebfJ91fAReKJVdXwm8GimoBZKqE2lntFnIA== X-Received: by 2002:a05:600c:3ba4:b0:434:fecf:cb2f with SMTP id 5b1f17b1804b1-436e26ef077mr41987185e9.5.1736513010634; Fri, 10 Jan 2025 04:43:30 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.165]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436dcc8f8dfsm81574515e9.0.2025.01.10.04.43.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 04:43:30 -0800 (PST) Message-ID: <6ee02d22-7a00-4c7c-a5e9-63e91d7d84ba@linaro.org> Date: Fri, 10 Jan 2025 13:43:28 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 08/11] drm/msm/dsi: Add support for SM8750 To: Dmitry Baryshkov Cc: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Manikandan , Jonathan Marek , Kuogee Hsieh , Neil Armstrong , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Srini Kandagatla References: <20250109-b4-sm8750-display-v1-0-b3f15faf4c97@linaro.org> <20250109-b4-sm8750-display-v1-8-b3f15faf4c97@linaro.org> <3p7kjok5jzwvgt7dxuad26xgdkjd52v4gbtuudvgkeoj33skqn@afl2ddtsq7s2> <4fc7fdd5-36cd-42e6-af4a-e0e429f9f50b@linaro.org> <7eupqawhdrbjgsj2p7e3ky7uj62m252i6dzkb6y23btocedp3q@qmw72nmbk2c4> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <7eupqawhdrbjgsj2p7e3ky7uj62m252i6dzkb6y23btocedp3q@qmw72nmbk2c4> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/01/2025 10:17, Dmitry Baryshkov wrote: > On Fri, Jan 10, 2025 at 09:59:26AM +0100, Krzysztof Kozlowski wrote: >> On 10/01/2025 00:18, Dmitry Baryshkov wrote: >>> On Thu, Jan 09, 2025 at 02:08:35PM +0100, Krzysztof Kozlowski wrote: >>>> Add support for DSI PHY v7.0 on Qualcomm SM8750 SoC which comes with two >>>> differences worth noting: >>>> >>>> 1. ICODE_ACCUM_STATUS_LOW and ALOG_OBSV_BUS_STATUS_1 registers - their >>>> offsets were just switched. Currently these registers are not used >>>> in the driver, so the easiest is to document both but keep them >>>> commented out to avoid conflict. >>>> >>>> 2. DSI PHY PLLs, the parents of pixel and byte clocks, cannot be used as >>>> parents before they are prepared and initial rate is set. Therefore >>>> assigned-clock-parents are not working here and driver is responsible >>>> for reparenting clocks with proper procedure: see dsi_clk_init_6g_v2_9(). >>> >>> Isn't it a description of CLK_SET_PARENT_GATE and/or >> >> No - must be gated accross reparent - so opposite. >> >>> CLK_OPS_PARENT_ENABLE ? >> >> Yes, but does not work. Probably enabling parent, before >> assigned-clocks-parents, happens still too early: >> >> [ 1.623554] DSI PLL(0) lock failed, status=0x00000000 >> [ 1.623556] PLL(0) lock failed >> [ 1.624650] ------------[ cut here ]------------ >> [ 1.624651] disp_cc_mdss_byte0_clk_src: rcg didn't update its >> configuration. >> >> Or maybe something is missing in the DSI PHY PLL driver? > > Do you have the no-zero-freq workaround? Yes, it is necessary also for my variant. I did not include it here, but I should mention it in the cover letter. Best regards, Krzysztof