From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [RFC PATCH 1/4] dts: misc: Add bindings documentation for bmc-misc-ctrl Date: Wed, 04 Jul 2018 01:39:53 +1000 Message-ID: <6f0c3d6d81202e385fee55a2c8aaec18d1d2acda.camel@kernel.crashing.org> References: <20180703070413.28756-1-andrew@aj.id.au> <20180703070413.28756-2-andrew@aj.id.au> <20180703075009.GA27649@kroah.com> <20180703143109.GB2043@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180703143109.GB2043@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Greg KH Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, Andrew Jeffery , Eugene.Cho@dell.com, a.amelkin@yadro.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, joel@jms.id.au, stewart@linux.ibm.com, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Tue, 2018-07-03 at 16:31 +0200, Greg KH wrote: > On Wed, Jul 04, 2018 at 12:16:49AM +1000, Benjamin Herrenschmidt wrote: > > On Tue, 2018-07-03 at 09:50 +0200, Greg KH wrote: > > > On Tue, Jul 03, 2018 at 05:04:10PM +1000, Andrew Jeffery wrote: > > > > Signed-off-by: Andrew Jeffery > > > > --- > > > > > > I can't take patches without any changelog text at all :( > > > > Greg (and replying to your other comments as well)... > > > > This is an RFC series, it's not meant for you to take at this point, > > it's about discussing the overall approach to exposing BMC random > > "tunables" as explained in patch 0 of the series. > > > > Yes the individual patches aren't yet at the level of polish for a > > formal submission, we (naively ?) thought that's what the whole RFC tag > > is about :-) > > Oh come on, putting a basic "here is what this patch does" comment > should be part of every patch, otherwise what is there to comment on if > we don't know what is going on in the patch itself? Well, it adds documentation :-) You can just read the patch which is ... the documentation :) > > Anyway, I provided a bunch of feedback to the "real" patch in this > series... Yes, you did that's fine. Thanks. Cheers, Ben.