From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: usb: gpio-sbu-mux: Add OnSemi NB7VPQ904M mux
Date: Fri, 31 Mar 2023 01:00:56 +0200 [thread overview]
Message-ID: <6f2c8609-0733-c1f6-210f-3d6f3d987c23@linaro.org> (raw)
In-Reply-To: <20230330153116.GA2181381-robh@kernel.org>
On 30.03.2023 17:31, Rob Herring wrote:
> On Tue, Mar 21, 2023 at 11:12:28PM +0100, Konrad Dybcio wrote:
>> The OnSemi NB7VPQ904M Type-C DP altmode redriver provides SBU signals
>> that can be used in with the gpio-sbu-mux driver. Document it.
>>
>> Note that the -mux suffix is there to indicate that the gpio-sbu-mux
>> driver interacts with the mux part of this otherwise quite sophisticated
>> chip, leaving the "onnn,nb7vpq904m" compatible free for when a proper
>> driver taking care of all of the chip's capabilities is introduced.
>
> You should define a proper and complete binding. If you want to bind the
> gpio-sbu-mux driver to it now until you have a proper driver then that's
> fine. When you have such a driver, then you drop the compatible from the
> gpio-sbu-mux driver.
Okay, that makes perfect sense and is good to know. Perhaps even worth
documenting somewhere.
I think I'll delay resending this and get an "actual" driver going.
Konrad
>
> Note that having the fallback "gpio-sbu-mux" is somewhat problematic
> because the kernel has no mechanism to ensure you bind the most specific
> driver. For that to happen, it would have to support (automatically)
> unbinding one driver and binding to the more specific driver since one
> driver could be built-in and the other a module.
>
> Rob
next prev parent reply other threads:[~2023-03-30 23:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 22:12 [PATCH 0/4] Enable DisplayPort over USB-C on SONY Sagami Konrad Dybcio
2023-03-21 22:12 ` [PATCH 1/4] dt-bindings: usb: gpio-sbu-mux: Add OnSemi NB7VPQ904M mux Konrad Dybcio
2023-03-30 15:31 ` Rob Herring
2023-03-30 23:00 ` Konrad Dybcio [this message]
2023-03-21 22:12 ` [PATCH 2/4] arm64: dts: qcom: sm8350-sagami: Add PMIC GLINK Konrad Dybcio
2023-03-30 16:33 ` Neil Armstrong
2023-03-21 22:12 ` [PATCH 3/4] arm64: dts: qcom: sm8350-sagami: Hook up USB-C Display Port Konrad Dybcio
2023-03-21 22:12 ` [PATCH 4/4] arm64: dts: qcom: sm8350-nagara: Unify status property placement Konrad Dybcio
2023-03-30 16:32 ` Neil Armstrong
2023-04-02 15:19 ` Marijn Suijten
2023-04-03 10:17 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f2c8609-0733-c1f6-210f-3d6f3d987c23@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).