Re: [PATCH v3 1/2] dt-bindings: bridge: This patch adds new content to the lontium,lt9611.yaml binding file

杨孙运
2026-04-21T03:40:03Z

Krzysztof Kozlowski <krzk@kernel.org> 于2026年4月20日周一 22:18写道：
>
> On 20/04/2026 16:15, Krzysztof Kozlowski wrote:
> > On Mon, Apr 20, 2026 at 01:33:46PM +0200, Krzysztof Kozlowski wrote:
> >>> -audio
> >>> 1.sample rates of 32~192 KHz and sample sizes
> >>> of 16~24 bits
> >>> 2.SPDIF interface supports PCM, Dolbydigital, DTS digital audio
> >>> at up to 192KHz frame rate
> >>>
> >>> -Miscellaneous
> >>> 1.CSC:RGB<->YUV444<->YUV422
> >>
> >> Commit msg is not a datasheet introduction chapter. What does this all
> >> mean for compatibility? What is the benefit of listing all this?
> >>
> >> You did not even explain the differences between C, UX and EXD, so all
> >> above is pointless. Explain the differences and why devices are not
> >> compatible.
> >>

First of all, I'm sorry for the trouble I've caused you.

Secondly, when adding a new chip, my intention in writing this was to
let reviewers understand the chip's capabilities.

Then, the C, EX, and UXD are a series of chips within the same product
family, with differences in hardware features:

- LT9611UXD: Supports 2-port MIPI DSI → HDMI 1.4/2.0
- LT9611C: Supports 1-port MIPI DSI → HDMI 1.4
- LT9611EX: Supports 2-port MIPI DSI → HDMI 1.4

Finally, it will be fixed in the next version.

> >
> > Also, you have checkpatch errors.
> >
it will be fixed in the next version.

>
> ... and finally (apologies for making it in three emails, checkpatch
> warnings come from different toolset): your subject is pretty breaking
> every standard rule.
>
> It's redundant, not informative in various ways. It misses proper
> prefix, it misses even basic description WHAT. Everything can be a "new
> content".
>
it will be fixed in the next version.

> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94
>
> Drop second/last, redundant "bindings". The "dt-bindings" prefix is
> already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
>
> And obviously "file" is pointless. Can you add content NOT to a file?
> Like add it to a directory?
>

it will be fixed in the next version. thks

>
> Best regards,
> Krzysztof