From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 673BBC43217 for ; Tue, 15 Nov 2022 08:15:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232696AbiKOIP3 (ORCPT ); Tue, 15 Nov 2022 03:15:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232693AbiKOIP0 (ORCPT ); Tue, 15 Nov 2022 03:15:26 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35E531F9FF for ; Tue, 15 Nov 2022 00:15:25 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id be13so23267694lfb.4 for ; Tue, 15 Nov 2022 00:15:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=enMJEB6RE4BXUjUBUVifULdEDFjDH1GCyA7BarCBlQQ=; b=VGV9FPacsX/KecYXujtFsg3MpccDS7AWbW3UoaR3FeYx/jVsj3+ImRxAOCrOgKwTbI DGvvZFERmQZR6cb8KNOTFimba+YBzrwapVNLu4c8KhZJS1mt0iAcLaKhCbRFM6aSKEqj E6YTbH5F13N4bL+0ZseZ8kRBKrIE+O8kXDwt4nCRlJMViq14fR65ZgvNL13pgs08LDwj UtbU0ATmbZxb51P6yrod/ciZqWxyNXYtjI1TKKKPJwE4tE3XyRYAJupf0oTla25Bd8zw POHkf01v5DbbVMw2m8ev6RkYeD26oo7qISNEBunWKdnFYbCkPHjCpKa1PPAAj2bzqCVY s8Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=enMJEB6RE4BXUjUBUVifULdEDFjDH1GCyA7BarCBlQQ=; b=TCSG2bec1Hufq4B4b7WPVgABHzcnK0y1qESrqFZRsQlLBVEnAXg6oDXmqml3wFXXVF 2sO0LrPJFqU68Wj2tG+skxzyQuDzWRLu+lO5HEgq1laBa/4irAkKwlV/GOZ7r53D02xN ImstWM8niu0swIr3YHhcJUnMLsVBwmy2jiXlLJItT62/DJm4ujuV9byXYP+zWf5bv/BT RSjmAL4M6cpjmWTdhnF/sOqiEn2QsCCQYTmMccccpEx0JQ29gvFGWEAApXClNafKWlXo +0SeUuX00332iCmKbkdRK53gxsNturpOFlbgDhfwdm8XxBMzagGKNKC6Z6g++9dgRlyg bS/A== X-Gm-Message-State: ANoB5pnLaKlFvXJiYDacRG+58seHmn4VPhS/ex3NukTILX9yWvLY1eCK BlE3s2JKXvaKq9jOv5uPCkRCqQ== X-Google-Smtp-Source: AA0mqf6W82OuHIEKY8hHMTm5amPDDvKoKhZTgo7QjbD0d20a3Mvds/Zs6do8IILNDIGWLo83qvk1+w== X-Received: by 2002:a05:6512:52e:b0:4b1:753b:e677 with SMTP id o14-20020a056512052e00b004b1753be677mr4790614lfc.407.1668500123544; Tue, 15 Nov 2022 00:15:23 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id a27-20020a2eb55b000000b0026e8b82eba6sm2393602ljn.34.2022.11.15.00.15.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 00:15:23 -0800 (PST) Message-ID: <6f3a8e24-ab1a-afe3-e907-22d1096a9f53@linaro.org> Date: Tue, 15 Nov 2022 09:15:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 3/5] dt-bindings: net: ipq4019-mdio: require and validate clocks Content-Language: en-US To: Robert Marko , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221114194734.3287854-1-robimarko@gmail.com> <20221114194734.3287854-3-robimarko@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20221114194734.3287854-3-robimarko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/11/2022 20:47, Robert Marko wrote: > Now that we can match the platforms requiring clocks by compatible start > using those to allow clocks per compatible and make them required. > > Signed-off-by: Robert Marko > --- > Changes in v2: > * Keep clocks under properties and disallow per compatible > --- > .../bindings/net/qcom,ipq4019-mdio.yaml | 27 ++++++++++++++----- > 1 file changed, 20 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml > index f4918c9e6fd2..72561e3aeee3 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml > @@ -9,9 +9,6 @@ title: Qualcomm IPQ40xx MDIO Controller > maintainers: > - Robert Marko > > -allOf: > - - $ref: "mdio.yaml#" > - > properties: > compatible: > oneOf: > @@ -40,10 +37,8 @@ properties: > address range is only required by the platform IPQ50xx. > > clocks: > - maxItems: 1 > - description: | > - MDIO clock source frequency fixed to 100MHZ, this clock should be specified > - by the platform IPQ807x, IPQ60xx and IPQ50xx. > + items: > + - description: MDIO clock source frequency fixed to 100MHZ > > required: > - compatible > @@ -51,6 +46,24 @@ required: > - "#address-cells" > - "#size-cells" > > +allOf: > + - $ref: "mdio.yaml#" If there is going to be resend, drop the quotes from above during the move. Anyway: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof