From: Michael Walle <michael@walle.cc>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC net-next 3/3] net: phy: mscc-miim: add support to set MDIO bus frequency
Date: Thu, 31 Mar 2022 18:44:41 +0200 [thread overview]
Message-ID: <6f67f53e262bf6eb93a3db572b966f9e@walle.cc> (raw)
In-Reply-To: <YkXWkaVRp4I1Gj0p@lunn.ch>
Am 2022-03-31 18:28, schrieb Andrew Lunn:
>> @@ -295,21 +323,41 @@ static int mscc_miim_probe(struct
>> platform_device *pdev)
>> if (!miim->info)
>> return -EINVAL;
>>
>> - ret = of_mdiobus_register(bus, pdev->dev.of_node);
>> + miim->clk = devm_clk_get_optional(&pdev->dev, NULL);
>> + if (IS_ERR(miim->clk))
>> + return PTR_ERR(miim->clk);
>> +
>> + ret = clk_prepare_enable(miim->clk);
>> + if (ret)
>> + return ret;
>> +
>> + of_property_read_u32(np, "clock-frequency", &miim->clk_freq);
>
> The clock is optional if there is no "clock-frequency" property. If
> the property does exist, the clock should be mandatory. I don't think
> it should silently fail setting the bus frequency because the clock is
> missing.
Oh yes, agreed.
-michael
next prev parent reply other threads:[~2022-03-31 16:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 15:14 [PATCH RFC net-next 1/3] dt-bindings: net: convert mscc-miim to YAML format Michael Walle
2022-03-31 15:14 ` [PATCH RFC net-next 2/3] dt-bindings: net: mscc-miim: add clock and clock-frequency Michael Walle
2022-03-31 20:05 ` Krzysztof Kozlowski
2022-03-31 20:16 ` Andrew Lunn
2022-03-31 20:30 ` Krzysztof Kozlowski
2022-03-31 15:14 ` [PATCH RFC net-next 3/3] net: phy: mscc-miim: add support to set MDIO bus frequency Michael Walle
2022-03-31 16:28 ` Andrew Lunn
2022-03-31 16:44 ` Michael Walle [this message]
2022-03-31 15:18 ` [PATCH RFC net-next 1/3] dt-bindings: net: convert mscc-miim to YAML format Michael Walle
2022-03-31 20:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f67f53e262bf6eb93a3db572b966f9e@walle.cc \
--to=michael@walle.cc \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).