From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74DA6C76196 for ; Tue, 11 Apr 2023 21:09:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229621AbjDKVJa (ORCPT ); Tue, 11 Apr 2023 17:09:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbjDKVJ3 (ORCPT ); Tue, 11 Apr 2023 17:09:29 -0400 Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 338C540F4 for ; Tue, 11 Apr 2023 14:09:28 -0700 (PDT) Received: by mail-io1-xd34.google.com with SMTP id d186so3704553iog.12 for ; Tue, 11 Apr 2023 14:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681247367; x=1683839367; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e5Fqe2TWJg4JQvlVCDVhDYu+cpARd8OUv1aMwqepO+E=; b=LDT/iLh2fO4h9CGyyTzcDHHx1VMD4/yj8QpKTtPr3CpuvPjKgHmZI3buA4zSfHMD4A Uv5PyeIr8z0ZV81KKJza/KV96iwGhP0N4IO6/8cfUvlZyMOKUJfcnSkb3SKrcx4p3XuT R1M1kUAFQQLDIYJp5Fgyvu4bapJ3lmKdjzbo+LU8OjqtAoD+NgbvRiu8CNQT5SPRmbUi JUwi9vVVrwxkH3zC/VOQNcjzuK7EaLD6QyLBhTXL7Xr8aVeLUjVE4OdBSs5/AttrPo2v s31PAUJ7FTCnsOMg+0lo0hQwqhlXsdSS9z3eS0SYH3Nw3u9PYr1prKMQ1DTTRG+F0oqV +KQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681247367; x=1683839367; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e5Fqe2TWJg4JQvlVCDVhDYu+cpARd8OUv1aMwqepO+E=; b=Y6GkmYAFwtgrhgXq49DT+H3INKi6P9ScvQC4FGgspF/Y5VW/FWeCSZrmn20h42sWsr vvaMXoARANmUTc2/0wdz+75h2X8b+evRnwqQliswxcHLCj7AvvgIhn6Jygdwr4a8uHwb GNeMYKkzNLlBZ6mtDpw0tQBkG1lWRkTptRLSBJp7z3xidHbWy5qKS1zYjC0fWlwJF+l8 poDOc8iaIFczZSs/rOdkfHAofc88d/BClurs/3+FK7SwmH7OUqWHWxge2edaoEN09cG5 5FotvwzwmpiQvemmKeLxWDHeSRvi7o49fFb/I38c9uJi6SpGvuCvF1Xh9R32QQr24kTA 9X5A== X-Gm-Message-State: AAQBX9dyEQAoi93GWpD0cLzK4Quz5kc2+DMKCcFhu+Qztz1gB1dXeJ8+ 5uuEkkRjXu/ocu6qybwOwCBD2A== X-Google-Smtp-Source: AKy350Y2FUSewhTp6knjCVBEbrgvEPREbj88THm4RouFUh75P4YiCm+qzi6OVVaRyPx8lnXTUGe/cw== X-Received: by 2002:a5d:8615:0:b0:704:b905:e652 with SMTP id f21-20020a5d8615000000b00704b905e652mr2802579iol.11.1681247367540; Tue, 11 Apr 2023 14:09:27 -0700 (PDT) Received: from [10.211.55.3] ([98.61.227.136]) by smtp.gmail.com with ESMTPSA id h8-20020a022b08000000b0040639da0a02sm4133266jaa.135.2023.04.11.14.09.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Apr 2023 14:09:27 -0700 (PDT) Message-ID: <6f6d8640-42cd-beae-a57a-50d9ff927ea5@linaro.org> Date: Tue, 11 Apr 2023 16:09:25 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v11 13/26] gunyah: vm_mgr: Add ioctls to support basic non-proxy VM boot Content-Language: en-US To: Elliot Berman , Srinivas Kandagatla , Alex Elder , Prakruthi Deepak Heragu Cc: Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Bagas Sanjaya , Will Deacon , Andy Gross , Catalin Marinas , Jassi Brar , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230304010632.2127470-1-quic_eberman@quicinc.com> <20230304010632.2127470-14-quic_eberman@quicinc.com> From: Alex Elder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 4/11/23 4:07 PM, Elliot Berman wrote: > > > On 3/21/2023 7:24 AM, Srinivas Kandagatla wrote: > >> On 04/03/2023 01:06, Elliot Berman wrote: >>> + >>> +#define GH_VM_START        _IO(GH_IOCTL_TYPE, 0x3) >> A comment here that this is going to *ONLY* start an un-authenticated >> VM would be useful to the users. >> > > There is only support for unauthenticated VM in the UAPI being proposed > and I'd like to re-use GH_VM_START ioctl for other VM types as well. Is > the comment really useful? I can easily see forgetting to remove the > comment and then being more confusing once the other VM types get added. It's up to you. And in general, I think your responses to my comments have been fine--even when you just explain why you don't plan to implement my suggestion. Thank you. -Alex > > Thanks, > Elliot