From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kris Chaplin <kris.chaplin@amd.com>, Conor Dooley <conor@kernel.org>
Cc: thomas.delev@amd.com, michal.simek@amd.com, robh+dt@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, git@amd.com
Subject: Re: [PATCH 1/2] dt-bindings: w1: Add YAML DT Schema for AMD w1 master and MAINTAINERS entry
Date: Fri, 13 Oct 2023 17:29:33 +0200 [thread overview]
Message-ID: <6fa74ee3-a2ef-4d76-964f-51249f53cbaa@linaro.org> (raw)
In-Reply-To: <c58fbddb-cda1-e0de-8ad9-e4701c2c73cb@amd.com>
On 13/10/2023 17:23, Kris Chaplin wrote:
>
> On 13/10/2023 16:07, Conor Dooley wrote:
>> On Fri, Oct 13, 2023 at 05:04:32PM +0200, Krzysztof Kozlowski wrote:
>>>
>>> That's a quite generic compatible. axi is ARM term, 1-wire is the name
>>> of the bus and master is the role. Concatenating three common words does
>>> not create unique device name. Compatibles are supposed to be specific
>>> and this is really relaxed. Anything can be over AXI, everything in
>>> 1wire is 1wire and every master device is a master.
>> Given the vendor (and the title of the binding) this is almost certainly
>> an FPGA IP core, so the generic name is understandable. Using the exact
>> name of the IP in the AMD/Xilinx catalog probably is the best choice?
>
> Indeed this is an Programmable Logic IP core - the official name of the
> core in our catalog is axi_1wire_master. It is a soft HDL core.
AMD product managers are highly skilled in naming things. Sigh.
Go ahead with AXI 1-wire master. Any future - from now to next 100 years
- product from AMD which will be different but sold under the same name,
thus creating conflict in compatible naming, should be rejected because
of that conflict or renamed to something else. If that happen I will
propose a name like "banana-wire".
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-13 15:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 9:30 [PATCH 0/2] w1: Add 1-wire master driver for AMD programmable logic IP Core Kris Chaplin
2023-10-13 9:30 ` [PATCH 1/2] dt-bindings: w1: Add YAML DT Schema for AMD w1 master and MAINTAINERS entry Kris Chaplin
2023-10-13 15:01 ` Conor Dooley
2023-10-13 15:04 ` Krzysztof Kozlowski
2023-10-13 15:07 ` Conor Dooley
2023-10-13 15:22 ` Krzysztof Kozlowski
2023-10-13 15:23 ` Kris Chaplin
2023-10-13 15:29 ` Krzysztof Kozlowski [this message]
2023-10-13 15:36 ` Kris Chaplin
2023-10-13 17:18 ` Rob Herring
2023-10-13 17:58 ` Kris Chaplin
2023-10-13 9:30 ` [PATCH 2/2] w1: Add 1-wire master driver for AMD programmable logic IP Core Kris Chaplin
2023-10-13 15:20 ` Krzysztof Kozlowski
2023-10-18 15:54 ` Kris Chaplin
2023-10-18 16:00 ` Krzysztof Kozlowski
2023-10-19 14:24 ` [PATCH v2 0/2] w1: Add AXI 1-wire host driver for AMD programmable logic IP core Kris Chaplin
2023-10-19 14:24 ` [PATCH v2 1/2] dt-bindings: w1: Add YAML DT schema for AMD AXI w1 host and MAINTAINERS entry Kris Chaplin
2023-10-19 14:30 ` Conor Dooley
2023-10-19 14:35 ` Michal Simek
2023-10-19 14:39 ` Kris Chaplin
2023-10-19 14:24 ` [PATCH v2 2/2] w1: Add AXI 1-wire host driver for AMD programmable logic IP core Kris Chaplin
2023-10-19 14:28 ` [PATCH v2 0/2] " Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fa74ee3-a2ef-4d76-964f-51249f53cbaa@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=kris.chaplin@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=robh+dt@kernel.org \
--cc=thomas.delev@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).