From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: “Ryan <ryan.lee.analog@gmail.com>,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, krzysztof.kozlowski@linaro.org,
rf@opensource.cirrus.com, ckeepax@opensource.cirrus.com,
herve.codina@bootlin.com, wangweidong.a@awinic.com,
james.schulman@cirrus.com,
ajye_huang@compal.corp-partner.google.com, shumingf@realtek.com,
povik+lin@cutebit.org, flatmax@flatmax.com,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
ryans.lee@analog.com
Subject: Re: [PATCH V2 1/2] ASoC: max98363: add soundwire amplifier driver
Date: Mon, 13 Mar 2023 09:46:31 -0500 [thread overview]
Message-ID: <6fbd4471-9f72-c87c-3803-90f7224abce0@linux.intel.com> (raw)
In-Reply-To: <20230311011409.210014-1-ryan.lee.analog@gmail.com>
> + ret = sdw_stream_add_slave(max98363->slave, &stream_config,
> + &port_config, 1, stream);
> + if (ret) {
> + dev_err(dai->dev, "Unable to configure port\n");
> + return ret;
> + }
> +
> + if (params_channels(params) > 16) {
> + dev_err(component->dev, "Unsupported channels %d\n",
> + params_channels(params));
> + return -EINVAL;
> + }
Do you actually support more than 8 channels?
The data port DPnPrepareCtl and DPn_ChannelEn registers expose 8
channels max. It's always possible to 'cheat' by packing two channels in
the same sample, but that would require custom signaling between manager
and peripheral that isn't present.
Could it be a left-over from a TDM implementation?
The rest of the patch looks fine.
next prev parent reply other threads:[~2023-03-13 17:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 1:14 [PATCH V2 1/2] ASoC: max98363: add soundwire amplifier driver “Ryan
2023-03-11 1:14 ` [PATCH V2 2/2] ASoC: dt-bindings: max98363: add soundwire amplifier “Ryan
2023-03-11 9:10 ` Krzysztof Kozlowski
2023-03-17 17:22 ` Lee, RyanS
2023-03-13 14:46 ` Pierre-Louis Bossart [this message]
2023-03-23 17:51 ` [PATCH V2 1/2] ASoC: max98363: add soundwire amplifier driver Lee, RyanS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fbd4471-9f72-c87c-3803-90f7224abce0@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=ajye_huang@compal.corp-partner.google.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=flatmax@flatmax.com \
--cc=herve.codina@bootlin.com \
--cc=james.schulman@cirrus.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=povik+lin@cutebit.org \
--cc=rf@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=ryan.lee.analog@gmail.com \
--cc=ryans.lee@analog.com \
--cc=shumingf@realtek.com \
--cc=tiwai@suse.com \
--cc=wangweidong.a@awinic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).