From: Krzysztof Kozlowski <krzk@kernel.org>
To: Eddie James <eajames@linux.ibm.com>, linux-i2c@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
andi.shyti@kernel.org
Subject: Re: [PATCH v5] dt-bindings: i2c: i2c-fsi: Convert to json-schema
Date: Tue, 21 May 2024 09:36:46 +0200 [thread overview]
Message-ID: <6feed165-8cd8-419c-ac86-f637adb79458@kernel.org> (raw)
In-Reply-To: <f23e2669-c5b9-4257-ad75-f1431690a544@linux.ibm.com>
On 20/05/2024 16:56, Eddie James wrote:
>
> On 5/19/24 13:03, Krzysztof Kozlowski wrote:
>> On 14/05/2024 22:54, Eddie James wrote:
>>
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - ibm,i2c-fsi
>>> +
>>> + reg:
>>> + items:
>>> + - description: FSI slave address
>>> +
>>> + "#address-cells":
>>> + const: 1
>>> +
>>> + "#size-cells":
>>> + const: 0
>>> +
>>> +patternProperties:
>>> + "^i2c(@.*)?":
>> Either you have or you have not unit addresses. Please fix the pattern.
>> Why is this so flexible? Do you want to deprecate i2c-bus in favor of
>> i2c? If so, then example should use new naming. I am fine with children
>> as i2c-bus, assuming this is allowed by dtschema. Did you actually test it?
>
>
> This is the exact pattern of the i2c-controller schema node name, which
> I thought would be good. I can make it more specific. But yes I tested
> it, i2c-bus works fine
i2c-controller schema is a generic schema, applicable to various cases,
including non-MMIO. You have here specific instances.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-05-21 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 20:54 [PATCH v5] dt-bindings: i2c: i2c-fsi: Convert to json-schema Eddie James
2024-05-19 18:03 ` Krzysztof Kozlowski
2024-05-20 14:56 ` Eddie James
2024-05-21 7:36 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6feed165-8cd8-419c-ac86-f637adb79458@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).