From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au,
venture@google.com, yuenn@google.com, benjaminfair@google.com,
jic23@kernel.org, minyard@acm.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
openbmc@lists.ozlabs.org,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] dt-binding: ipmi: add fallback to npcm845 compatible
Date: Thu, 4 Aug 2022 17:01:08 +0200 [thread overview]
Message-ID: <6fef92f3-6932-5c20-57fe-9eb40d676013@molgen.mpg.de> (raw)
In-Reply-To: <20220804145516.217482-1-tmaimon77@gmail.com>
Dear Tomer,
Am 04.08.22 um 16:55 schrieb Tomer Maimon:
> Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible
> string.
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
> Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> index cbc10a68ddef..4fda76e63396 100644
> --- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> +++ b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> @@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host.
> Required properties:
> - compatible : should be one of
> "nuvoton,npcm750-kcs-bmc"
> - "nuvoton,npcm845-kcs-bmc"
> + "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc"
Isn’t the added string exactly the same as the one below the compatible
line?
> - interrupts : interrupt generated by the controller
> - kcs_chan : The KCS channel number in the controller
Kind regards,
Paul
next prev parent reply other threads:[~2022-08-04 15:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 14:55 [PATCH v1] dt-binding: ipmi: add fallback to npcm845 compatible Tomer Maimon
2022-08-04 15:01 ` Paul Menzel [this message]
2022-08-04 15:40 ` Tomer Maimon
2022-08-04 15:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fef92f3-6932-5c20-57fe-9eb40d676013@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openbmc@lists.ozlabs.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).