Devicetree
 help / color / mirror / Atom feed
From: Icenowy Zheng <icenowy@aosc.xyz>
To: Chen-Yu Tsai <wens@csie.org>
Cc: devicetree <devicetree@vger.kernel.org>,
	Linux-ALSA <alsa-devel@alsa-project.org>,
	Vinod Koul <vinod.koul@intel.com>,
	Mark Brown <broonie@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/9] ASoC: sun8i-codec-analog: add support for V3s SoC
Date: Sun, 26 Feb 2017 15:08:44 +0800	[thread overview]
Message-ID: <7002681488092924@web8j.yandex.ru> (raw)
In-Reply-To: <CAGb2v67YfVo7RhkAPUZusfJiCW-_m6-d-=uq-DdgjEWNKYWVsQ@mail.gmail.com>



26.02.2017, 14:16, "Chen-Yu Tsai" <wens@csie.org>:
> On Sat, Feb 25, 2017 at 8:30 PM, Icenowy Zheng <icenowy@aosc.xyz> wrote:
>>  The V3s SoC features an analog codec with headphone support but without
>>  mic2 and linein.
>
> It doesn't have MBIAS either. Please split it out as well.

Thanks for your tips ;-)

>
> ChenYu
>
>>  Add support for it.
>>
>>  Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>>  ---
>>   Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt | 1 +
>>   sound/soc/sunxi/sun8i-codec-analog.c | 9 +++++++++
>>   2 files changed, 10 insertions(+)
>>
>>  diff --git a/Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt b/Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt
>>  index 779b735781ba..1b6e7c4e50ab 100644
>>  --- a/Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt
>>  +++ b/Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt
>>  @@ -4,6 +4,7 @@ Required properties:
>>   - compatible: must be one of the following compatibles:
>>                  - "allwinner,sun8i-a23-codec-analog"
>>                  - "allwinner,sun8i-h3-codec-analog"
>>  + - "allwinner,sun8i-v3s-codec-analog"
>>
>>   Required properties if not a sub-node of the PRCM node:
>>   - reg: must contain the registers location and length
>>  diff --git a/sound/soc/sunxi/sun8i-codec-analog.c b/sound/soc/sunxi/sun8i-codec-analog.c
>>  index 6c17c99c2c8d..6375932177a3 100644
>>  --- a/sound/soc/sunxi/sun8i-codec-analog.c
>>  +++ b/sound/soc/sunxi/sun8i-codec-analog.c
>>  @@ -695,6 +695,11 @@ static const struct sun8i_codec_analog_quirks sun8i_h3_quirks = {
>>          .has_mic2 = true,
>>   };
>>
>>  +static const struct sun8i_codec_analog_quirks sun8i_v3s_quirks = {
>>  + .has_headphone = true,
>>  + .has_hmic = true,
>>  +};
>>  +
>>   static int sun8i_codec_analog_cmpnt_probe(struct snd_soc_component *cmpnt)
>>   {
>>          struct device *dev = cmpnt->dev;
>>  @@ -762,6 +767,10 @@ static const struct of_device_id sun8i_codec_analog_of_match[] = {
>>                  .compatible = "allwinner,sun8i-h3-codec-analog",
>>                  .data = &sun8i_h3_quirks,
>>          },
>>  + {
>>  + .compatible = "allwinner,sun8i-v3s-codec-analog",
>>  + .data = &sun8i_v3s_quirks,
>>  + },
>>          {}
>>   };
>>   MODULE_DEVICE_TABLE(of, sun8i_codec_analog_of_match);
>>  --
>>  2.11.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2017-02-26  7:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-25 12:30 [PATCH 1/9] ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock Icenowy Zheng
2017-02-25 12:30 ` [PATCH 2/9] ASoC: sun8i-codec-analog: split out linein and mic2 Icenowy Zheng
2017-02-26  6:06   ` Chen-Yu Tsai
2017-02-25 12:30 ` [PATCH 3/9] ASoC: sun8i-codec-analog: add support for V3s SoC Icenowy Zheng
2017-02-26  6:16   ` Chen-Yu Tsai
2017-02-26  7:08     ` Icenowy Zheng [this message]
2017-02-25 12:30 ` [PATCH 4/9] ASoC: sun4i-codec: Add support for V3s codec Icenowy Zheng
2017-02-25 12:30 ` [PATCH 5/9] dmaengine: sun6i: support V3s SoC variant Icenowy Zheng
2017-02-27  7:50   ` Maxime Ripard
2017-02-27 10:48     ` Icenowy Zheng
2017-02-28 17:56       ` Maxime Ripard
2017-02-28 17:58         ` Icenowy Zheng
2017-03-01  9:32           ` Maxime Ripard
2017-02-25 12:30 ` [PATCH 6/9] ARM: dts: sun8i: restore the inclusion of ccu headers in V3s DTSI Icenowy Zheng
2017-02-25 12:30 ` [PATCH 7/9] ARM: dts: sun8i: add DMA engine " Icenowy Zheng
2017-02-25 12:30 ` [PATCH 8/9] ARM: dts: sun8i: add audio codec support into " Icenowy Zheng
2017-02-25 12:30 ` [PATCH 9/9] ARM: dts: sun8i: enable audio on Lichee Pi Zero Dock Icenowy Zheng
2017-02-27  7:49 ` [PATCH 1/9] ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock Maxime Ripard
2017-02-28 23:02 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7002681488092924@web8j.yandex.ru \
    --to=icenowy@aosc.xyz \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=robh+dt@kernel.org \
    --cc=vinod.koul@intel.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox