From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CD3B3B9601 for ; Fri, 15 May 2026 14:49:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778856555; cv=none; b=LMiZafP8easf1EahYTOluy0f55LYXsZkOYS4/UryOccRAI9OjwcxXH3sblTYUH5swnI8Mjxq7BVtHQu+KaN1V8z+e0f1jgxmQ9sA2vUhaac/xtQiajlvPNVvaxhlhwFPN9plIT69F4j2sqc3DyfHOYob3NYzXbgPROpK+sxgq+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778856555; c=relaxed/simple; bh=mOv6Q8Fcxzbd/nWF/hITixM5c619MgiWAJDK0f0JBy8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZuqhM7W9Z4+pYzsBDO+uzq2FaoWQrP7emTv2J0f2NdorvHyWRNeZ3kTM660dlUVG4B2suQj1+DFOMo7YJqdWmhcIDLQD8PyV3XlE6wjSK/2KrwZ7n5/48HujUW1Ze4lS9zvyQRenDhv5d9RAYyQ/mvsldYj3Uc5kO24HVcqkRRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=rsXGA3OZ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=RxKftq7j; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=rsXGA3OZ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=RxKftq7j; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="rsXGA3OZ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="RxKftq7j"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="rsXGA3OZ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="RxKftq7j" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DEEA75C93F; Fri, 15 May 2026 14:49:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778856550; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7ru+fjFB/tNdq+tdFTOk5Iq5/99xUyuLD40hSwxkMX4=; b=rsXGA3OZUAWLpm4GJyWj1u0v4tql7wgi1jofVujLXiwoivjgDNcJW1YY0gV08cs+JqWpTm KO6lGMc8guTzlmHS2w+Y06luZsYcQcC5X1Q43+WzIkx38gjjhQ9XIWpelMKIyfGaJvROfD ZmxRbKfIfMfn+ergsO+UWj6mGAp3dAY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778856550; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7ru+fjFB/tNdq+tdFTOk5Iq5/99xUyuLD40hSwxkMX4=; b=RxKftq7j7MtIWVKnMldGLGoNKE9KpUkOFr0vKbm89Q6DrNY4GQeo+Gve1gyWwOWroVq74J uqL6G+8QVI/G5cBw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778856550; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7ru+fjFB/tNdq+tdFTOk5Iq5/99xUyuLD40hSwxkMX4=; b=rsXGA3OZUAWLpm4GJyWj1u0v4tql7wgi1jofVujLXiwoivjgDNcJW1YY0gV08cs+JqWpTm KO6lGMc8guTzlmHS2w+Y06luZsYcQcC5X1Q43+WzIkx38gjjhQ9XIWpelMKIyfGaJvROfD ZmxRbKfIfMfn+ergsO+UWj6mGAp3dAY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778856550; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7ru+fjFB/tNdq+tdFTOk5Iq5/99xUyuLD40hSwxkMX4=; b=RxKftq7j7MtIWVKnMldGLGoNKE9KpUkOFr0vKbm89Q6DrNY4GQeo+Gve1gyWwOWroVq74J uqL6G+8QVI/G5cBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7133F593A9; Fri, 15 May 2026 14:49:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Dsp0GmYyB2o2OwAAD6G6ig (envelope-from ); Fri, 15 May 2026 14:49:10 +0000 Message-ID: <70130cc3-593e-4811-8c22-3e7b6fbe79ad@suse.de> Date: Fri, 15 May 2026 16:49:09 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] drm/panel: Add driver for Novatek NT37705 panel To: Luca Weiss , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260501-fp6-panel-v1-0-e09cb05651cc@fairphone.com> <20260501-fp6-panel-v1-2-e09cb05651cc@fairphone.com> <4d4e8090-3216-4a41-9a7d-3d2c0998121a@suse.de> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; URIBL_BLOCKED(0.00)[suse.de:mid,suse.com:url,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_TO(0.00)[fairphone.com,linaro.org,gmail.com,linux.intel.com,kernel.org,ffwll.ch]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_TWELVE(0.00)[18]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TAGGED_RCPT(0.00)[dt]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:url,imap1.dmz-prg2.suse.org:helo,suse.de:mid] X-Spam-Level: Hi Am 15.05.26 um 16:43 schrieb Luca Weiss: [...] > I checked and include/linux/container_of.h states: > > Do not use container_of() in new code. > > and > > Always prefer container_of_const() instead of container_of() in new code. > > So sounds like using container_of_const() is the correct way. I didn't know that. Thanks! Best regards Thomas > >>>>> + >>>>> + ret = regulator_bulk_enable(ARRAY_SIZE(nt37705_supplies), ctx->supplies); >>>>> + if (ret < 0) { >>>> Common style is to check for errors with >>>> >>>>   if (ret) >>>> >>>> Here and everywhere else. >>> At least for regulator_bulk_enable() "ret < 0" is actually more popular >>> than just "ret". >>> >>> Kernel doc says "Return: 0 on success or a negative error number on >>> failure." so a positive integer should in theory never happen so they're >>> equivalent. >>> >>> (git grep -h -A2 regulator_bulk_enable | grep if | sed 's|^[ \t]\+||' | sed 's| {$||' | sort | uniq -c) >> It's just nitpicking, not a blocker. > I was also curious so I dug around a bit :) > > Regards > Luca -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)