From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: neil.armstrong@linaro.org, Rob Herring <robh+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Amol Maheshwari <amahesh@qti.qualcomm.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Andy Gross <agross@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, Abel Vesa <abel.vesa@linaro.org>,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v2 2/5] dt-bindings: remoteproc: qcom: adsp: document sm8550 adsp, cdsp & mpss compatible
Date: Fri, 2 Dec 2022 11:44:54 +0100 [thread overview]
Message-ID: <7015b64a-e73c-87aa-4e1f-a0034638c6ec@linaro.org> (raw)
In-Reply-To: <ace35de2-9aa8-8cfa-1f4c-46480fbbc442@linaro.org>
On 02/12/2022 11:33, Neil Armstrong wrote:
>>> +
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + enum:
>>> + - qcom,sm8550-cdsp-pas
>>> + then:
>>> + properties:
>>> + power-domains:
>>> + items:
>>> + - description: CX power domain
>>> + - description: MXC power domain
>>> + power-domain-names:
>>> + items:
>>> + - const: cx
>>> + - const: mxc
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + enum:
>>> + - qcom,sm8550-cdsp-pas
>>
>> This entire if does not look valid - compatible is covered in the
>> previous one. You should see `dtbs_check` warnings on your DTS.
>
> Wow indeed, this should be mpss-pas...
Then also drop "contains" to match other places (and other files).
>
> The main changes here was firmware-name and memory-region to handle
> the dtb firmware and the DSM memory region, are those OK ?
>
Yes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-02 10:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 10:29 [PATCH v2 0/5] remoteproc: qcom_q6v5_pas: add support for SM8550 adsp, cdsp & mpss Neil Armstrong
2022-11-30 10:29 ` [PATCH v2 1/5] dt-bindings: remoteproc: qcom: adsp: move memory-region and firmware-name out of pas-common Neil Armstrong
2022-12-01 10:54 ` Krzysztof Kozlowski
2022-12-02 10:31 ` Neil Armstrong
2022-11-30 10:29 ` [PATCH v2 2/5] dt-bindings: remoteproc: qcom: adsp: document sm8550 adsp, cdsp & mpss compatible Neil Armstrong
2022-11-30 13:47 ` Rob Herring
2022-12-01 10:58 ` Krzysztof Kozlowski
2022-12-02 10:33 ` Neil Armstrong
2022-12-02 10:44 ` Krzysztof Kozlowski [this message]
2022-11-30 10:29 ` [PATCH v2 3/5] remoteproc: qcom_q6v5_pas: add support for dtb co-firmware loading Neil Armstrong
2022-11-30 10:29 ` [PATCH v2 4/5] remoteproc: qcom_q6v5_pas: add support for assigning memory to firmware Neil Armstrong
2022-11-30 10:29 ` [PATCH v2 5/5] remoteproc: qcom_q6v5_pas: add sm8550 adsp, cdsp & mpss compatible & data Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7015b64a-e73c-87aa-4e1f-a0034638c6ec@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=amahesh@qti.qualcomm.com \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).