From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5196DC41513 for ; Tue, 8 Aug 2023 16:32:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231727AbjHHQcS (ORCPT ); Tue, 8 Aug 2023 12:32:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232921AbjHHQbC (ORCPT ); Tue, 8 Aug 2023 12:31:02 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A0AA1394C for ; Tue, 8 Aug 2023 08:51:39 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4fe216edaf7so8270609e87.0 for ; Tue, 08 Aug 2023 08:51:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691509891; x=1692114691; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Q24TuyQPIV9JKdXRN8c9UpIkwf6u74tQnVD/uWybcPY=; b=ooJUGKed+TqnLoPRl6/ha6jK7wklyRQsI22gMPmHZYx56xz56BLgMjYomwEfLBwhv1 NmpP5Sunf+xC99kRlxmp0wygDW4z4ZDN2NBdidVHzjGxTTjt/PF+Kp8hrOicutclfq0j KgwvCfCVzQplkvrZecxbVxyaNcWqsAmd3pbQcdt3h5W/NsWqO2KCwb+7elZtKCL+qfrS UB4RpgWJ+hK2cF0e/mfD6JZrie0SG2ZfVyYt+EoiLGzttAiaPpmob65dvAbMO3jE0z+O 5VdNAnFVkrls+BWtVSf2DK0w2mU/gkuprIyHvzPtDpgxPSaggD6qxcFb9WyoMIDyhu8K ailQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691509891; x=1692114691; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q24TuyQPIV9JKdXRN8c9UpIkwf6u74tQnVD/uWybcPY=; b=ROTQilEUUS5oBGpjxrGN5ngOuKxOl1UKe29JpZY1XmOsGvdVLzGQVGlNhZeJ2DGBv6 2ILkJxBe3efYbj2V3hZfiPzzu6dLt0gi4LIzGS7/s5B1LUrDuSKB/SIJRcNE0f3t1yTE uUIAV0j4pk1vXttLvHvodOv2a0GFUrmWyEnqdzgyx5fEVAOmR1bW5ouxHdNY8uxNVIDW zVNgdmdYAjtH2F2lKFc8ToF/BZ8Jmm+tWzknUe2BQ/Hq34Es0yhstmOpzyncCzgHXDEo zGJ1OZEUV4tOWi8lr0VuHsx/aFMf7trSM0Vh69qx4G5bT/nGaruw6A0LqrAV1d2rk9af 55vg== X-Gm-Message-State: AOJu0YxXaCOgQCAZ2E2JsreEZviCqkVj6wMEj03ig677pNaj6xfiedPu yHUCI1nkyFpUbqDosYE7sPn/QlpMbdU5si3jqgg= X-Google-Smtp-Source: AGHT+IH+83IRgkTcHHxGdoUT4Se5hAS8eTHNASuvSJa4UvMYgg41Fn4+QsSO9CRbFeCN7dZHSqw6Rg== X-Received: by 2002:a17:906:31d2:b0:99b:50ea:2f96 with SMTP id f18-20020a17090631d200b0099b50ea2f96mr68317ejf.12.1691506140661; Tue, 08 Aug 2023 07:49:00 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id le3-20020a170907170300b0099cf840527csm812527ejc.153.2023.08.08.07.48.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 07:49:00 -0700 (PDT) Message-ID: <701ad779-0d1e-e8e6-8eba-294452cfb0bc@linaro.org> Date: Tue, 8 Aug 2023 16:48:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [EXT] Re: [PATCH v4 2/7] arm64: dts: imx8ulp-evk: added nxp secure enclave firmware Content-Language: en-US To: Pankaj Gupta , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "clin@suse.com" , "conor+dt@kernel.org" , "pierre.gondois@arm.com" , Jacky Bai , Clark Wang , Wei Fang , Peng Fan , Bough Chen , "festevam@gmail.com" , dl-linux-imx , "davem@davemloft.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Gaurav Jain , "alexander.stein@ew.tq-group.com" , Sahil Malhotra , Aisheng Dong , Varun Sethi References: <20230712121219.2654234-1-pankaj.gupta@nxp.com> <20230712121219.2654234-3-pankaj.gupta@nxp.com> <1ac2fb68-02e0-ddfe-87aa-fcd093779009@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/08/2023 13:07, Pankaj Gupta wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Thursday, July 13, 2023 12:08 AM >> To: Pankaj Gupta ; shawnguo@kernel.org; >> s.hauer@pengutronix.de; kernel@pengutronix.de; clin@suse.com; >> conor+dt@kernel.org; pierre.gondois@arm.com; Jacky Bai >> ; Clark Wang ; Wei Fang >> ; Peng Fan ; Bough Chen >> ; festevam@gmail.com; dl-linux-imx > imx@nxp.com>; davem@davemloft.net; robh+dt@kernel.org; >> krzysztof.kozlowski+dt@linaro.org; linux-arm-kernel@lists.infradead.org; >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Gaurav Jain >> ; alexander.stein@ew.tq-group.com; Sahil Malhotra >> ; Aisheng Dong ; Varun >> Sethi >> Subject: [EXT] Re: [PATCH v4 2/7] arm64: dts: imx8ulp-evk: added nxp secure >> enclave firmware >> >> Caution: This is an external email. Please take care when clicking links or >> opening attachments. When in doubt, report the message using the 'Report >> this email' button >> >> >> On 12/07/2023 14:12, Pankaj Gupta wrote: >>> Added support for NXP secure enclave called EdgeLock Enclave firmware >>> (se-fw) for imx8ulp-evk. >>> >>> Signed-off-by: Pankaj Gupta >>> --- >>> arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 12 +++++++++++- >>> 1 file changed, 11 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi >>> b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi >>> index 3ddc0f3125b3..10ed31974a6f 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi >>> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi >>> @@ -114,7 +114,7 @@ sosc: clock-sosc { >>> #clock-cells = <0>; >>> }; >>> >>> - sram@2201f000 { >>> + sram0: sram@2201f000 { >>> compatible = "mmio-sram"; >>> reg = <0x0 0x2201f000 0x0 0x1000>; >>> >>> @@ -161,6 +161,16 @@ s4muap: mailbox@27020000 { >>> #mbox-cells = <2>; >>> }; >>> >>> + ele_fw: se-fw { >>> + compatible = "fsl,imx-ele"; >>> + mboxes = <&s4muap 0 0 &s4muap 1 0>; >>> + mbox-names = "tx", "rx"; >>> + fsl,mu-did = <7>; >>> + fsl,mu-id = <2>; >>> + sram-pool = <&sram0>; >> >> It does not look like you tested the DTS against bindings. Please run `make >> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst or >> https://www.li/ >> naro.org%2Fblog%2Ftips-and-tricks-for-validating-devicetree-sources-with- >> the-devicetree- >> schema%2F&data=05%7C01%7Cpankaj.gupta%40nxp.com%7Cd13d0b68d01c >> 4d10d8cb08db83070ed2%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0% >> 7C0%7C638247838553225400%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC >> 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7 >> C%7C%7C&sdata=pO6dnz4aPqVejRNDR0OU4n04hXebyqgrNKg4DPhahI0%3D >> &reserved=0 >> for instructions). > > Tested. Before submitting the patch. > [Pankaj] Accepted. You really tested that patch? Before I waste my time on proving it was not, are you 100% sure that you tested that patch and no new warnings are printed? Or are you just agreeing with me that this time you will test? > Best regards, Krzysztof