devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: qcom: sm8250: fix usb2 qmp phy node
       [not found] <20210706230702.299047-1-bryan.odonoghue@linaro.org>
@ 2021-07-06 23:07 ` Bryan O'Donoghue
  2021-07-06 23:26   ` Dmitry Baryshkov
  2021-07-07  0:04   ` Bjorn Andersson
  0 siblings, 2 replies; 5+ messages in thread
From: Bryan O'Donoghue @ 2021-07-06 23:07 UTC (permalink / raw)
  To: vkoul, kishon, agross, bjorn.andersson, linux-arm-msm, linux-phy
  Cc: robh+dt, jonathan, bryan.odonoghue, Dmitry Baryshkov, devicetree

From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Use 'lanes' as SuperSpeed lanes device node instead of just 'lane' to
fix issues with TypeC support.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fixes: be0624b99042 ("arm64: dts: qcom: sm8250: Add USB and PHY device nodes")
Cc: robh+dt@kernel.org
Cc: devicetree@vger.kernel.org
Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index 4c0de12aaba6..270d7ff59ec1 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -2123,7 +2123,7 @@ usb_2_qmpphy: phy@88eb000 {
 				 <&gcc GCC_USB3_PHY_SEC_BCR>;
 			reset-names = "phy", "common";
 
-			usb_2_ssphy: lane@88eb200 {
+			usb_2_ssphy: lanes@88eb200 {
 				reg = <0 0x088eb200 0 0x200>,
 				      <0 0x088eb400 0 0x200>,
 				      <0 0x088eb800 0 0x800>;
-- 
2.30.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] arm64: dts: qcom: sm8250: fix usb2 qmp phy node
  2021-07-06 23:07 ` [PATCH 1/2] arm64: dts: qcom: sm8250: fix usb2 qmp phy node Bryan O'Donoghue
@ 2021-07-06 23:26   ` Dmitry Baryshkov
  2021-07-06 23:29     ` Bryan O'Donoghue
  2021-07-07  0:04   ` Bjorn Andersson
  1 sibling, 1 reply; 5+ messages in thread
From: Dmitry Baryshkov @ 2021-07-06 23:26 UTC (permalink / raw)
  To: Bryan O'Donoghue
  Cc: Vinod Koul, Kishon Vijay Abraham I, Andy Gross, Bjorn Andersson,
	open list:DRM DRIVER FOR MSM ADRENO GPU, linux-phy, Rob Herring,
	Jonathan Marek,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

Him

On Wed, 7 Jul 2021 at 02:05, Bryan O'Donoghue
<bryan.odonoghue@linaro.org> wrote:
>
> From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> Use 'lanes' as SuperSpeed lanes device node instead of just 'lane' to
> fix issues with TypeC support.

I think this should not be required anymore, it is a leftover from the
previous series which used strcmp("lanes") to create phys.

>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Fixes: be0624b99042 ("arm64: dts: qcom: sm8250: Add USB and PHY device nodes")
> Cc: robh+dt@kernel.org
> Cc: devicetree@vger.kernel.org
> Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 4c0de12aaba6..270d7ff59ec1 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2123,7 +2123,7 @@ usb_2_qmpphy: phy@88eb000 {
>                                  <&gcc GCC_USB3_PHY_SEC_BCR>;
>                         reset-names = "phy", "common";
>
> -                       usb_2_ssphy: lane@88eb200 {
> +                       usb_2_ssphy: lanes@88eb200 {
>                                 reg = <0 0x088eb200 0 0x200>,
>                                       <0 0x088eb400 0 0x200>,
>                                       <0 0x088eb800 0 0x800>;
> --
> 2.30.1
>


--
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] arm64: dts: qcom: sm8250: fix usb2 qmp phy node
  2021-07-06 23:26   ` Dmitry Baryshkov
@ 2021-07-06 23:29     ` Bryan O'Donoghue
  0 siblings, 0 replies; 5+ messages in thread
From: Bryan O'Donoghue @ 2021-07-06 23:29 UTC (permalink / raw)
  To: Dmitry Baryshkov
  Cc: Vinod Koul, Kishon Vijay Abraham I, Andy Gross, Bjorn Andersson,
	open list:DRM DRIVER FOR MSM ADRENO GPU, linux-phy, Rob Herring,
	Jonathan Marek,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

On 07/07/2021 00:26, Dmitry Baryshkov wrote:
> Him
> 
> On Wed, 7 Jul 2021 at 02:05, Bryan O'Donoghue
> <bryan.odonoghue@linaro.org> wrote:
>>
>> From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>
>> Use 'lanes' as SuperSpeed lanes device node instead of just 'lane' to
>> fix issues with TypeC support.
> 
> I think this should not be required anymore, it is a leftover from the
> previous series which used strcmp("lanes") to create phys.
> 
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> Fixes: be0624b99042 ("arm64: dts: qcom: sm8250: Add USB and PHY device nodes")
>> Cc: robh+dt@kernel.org
>> Cc: devicetree@vger.kernel.org
>> Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> index 4c0de12aaba6..270d7ff59ec1 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> @@ -2123,7 +2123,7 @@ usb_2_qmpphy: phy@88eb000 {
>>                                   <&gcc GCC_USB3_PHY_SEC_BCR>;
>>                          reset-names = "phy", "common";
>>
>> -                       usb_2_ssphy: lane@88eb200 {
>> +                       usb_2_ssphy: lanes@88eb200 {
>>                                  reg = <0 0x088eb200 0 0x200>,
>>                                        <0 0x088eb400 0 0x200>,
>>                                        <0 0x088eb800 0 0x800>;
>> --
>> 2.30.1
>>
> 
> 
> --
> With best wishes
> Dmitry
> 

Ok great.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] arm64: dts: qcom: sm8250: fix usb2 qmp phy node
  2021-07-06 23:07 ` [PATCH 1/2] arm64: dts: qcom: sm8250: fix usb2 qmp phy node Bryan O'Donoghue
  2021-07-06 23:26   ` Dmitry Baryshkov
@ 2021-07-07  0:04   ` Bjorn Andersson
  2021-07-07  0:10     ` Bryan O'Donoghue
  1 sibling, 1 reply; 5+ messages in thread
From: Bjorn Andersson @ 2021-07-07  0:04 UTC (permalink / raw)
  To: Bryan O'Donoghue
  Cc: vkoul, kishon, agross, linux-arm-msm, linux-phy, robh+dt,
	jonathan, Dmitry Baryshkov, devicetree

On Tue 06 Jul 18:07 CDT 2021, Bryan O'Donoghue wrote:

> From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
> Use 'lanes' as SuperSpeed lanes device node instead of just 'lane' to
> fix issues with TypeC support.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Fixes: be0624b99042 ("arm64: dts: qcom: sm8250: Add USB and PHY device nodes")
> Cc: robh+dt@kernel.org
> Cc: devicetree@vger.kernel.org
> Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 4c0de12aaba6..270d7ff59ec1 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2123,7 +2123,7 @@ usb_2_qmpphy: phy@88eb000 {
>  				 <&gcc GCC_USB3_PHY_SEC_BCR>;
>  			reset-names = "phy", "common";
>  
> -			usb_2_ssphy: lane@88eb200 {
> +			usb_2_ssphy: lanes@88eb200 {

The uni-phy binding says that this should be named "^phy@[0-9a-f]+$"

So while Dmitry is right about the logic in the driver, it would be nice
if you would spin this patch to make us pass the dt-binding check -
which can be sent independently from the driver patch.

Regards,
Bjorn

>  				reg = <0 0x088eb200 0 0x200>,
>  				      <0 0x088eb400 0 0x200>,
>  				      <0 0x088eb800 0 0x800>;
> -- 
> 2.30.1
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] arm64: dts: qcom: sm8250: fix usb2 qmp phy node
  2021-07-07  0:04   ` Bjorn Andersson
@ 2021-07-07  0:10     ` Bryan O'Donoghue
  0 siblings, 0 replies; 5+ messages in thread
From: Bryan O'Donoghue @ 2021-07-07  0:10 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: vkoul, kishon, agross, linux-arm-msm, linux-phy, robh+dt,
	jonathan, Dmitry Baryshkov, devicetree

On 07/07/2021 01:04, Bjorn Andersson wrote:
> So while Dmitry is right about the logic in the driver, it would be nice
> if you would spin this patch to make us pass the dt-binding check -
> which can be sent independently from the driver patch.

ok

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-07-07  0:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20210706230702.299047-1-bryan.odonoghue@linaro.org>
2021-07-06 23:07 ` [PATCH 1/2] arm64: dts: qcom: sm8250: fix usb2 qmp phy node Bryan O'Donoghue
2021-07-06 23:26   ` Dmitry Baryshkov
2021-07-06 23:29     ` Bryan O'Donoghue
2021-07-07  0:04   ` Bjorn Andersson
2021-07-07  0:10     ` Bryan O'Donoghue

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).