From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marcus Glocker <marcus@nazgul.ch>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Abel Vesa <abel.vesa@linaro.org>,
Johan Hovold <johan@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Subject: Re: [PATCH v3 4/6] arm64: dts: qcom: Add UFS node
Date: Fri, 16 Aug 2024 09:21:03 +0200 [thread overview]
Message-ID: <70214a1a-82b9-4839-b95b-b75abf467eca@kernel.org> (raw)
In-Reply-To: <ejeph4wspggkmvhl7qmpvw5jlojyvma7epqd67i6vk5p6fncrk@de56nvgi6vzi>
On 15/08/2024 12:42, Marcus Glocker wrote:
> Add the UFS Host Controller node. This was basically copied from the
> arch/arm64/boot/dts/qcom/sc7180.dtsi file.
>
> Signed-off-by: Marcus Glocker <marcus@nazgul.ch>
> +
> + ufs_mem_phy: phy@1d87000 {
> + compatible = "qcom,x1e80100-qmp-ufs-phy";
> + reg = <0 0x01d87000 0 0x1000>;
> + clocks = <&rpmhcc RPMH_CXO_CLK>,
> + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
> + clock-names = "ref",
> + "ref_aux",
> + "qref";
One does not match the other.
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-16 7:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 10:36 [PATCH v3 0/6] Add initial DTS for Samsung Galaxy Book4 Edge Marcus Glocker
2024-08-15 10:38 ` [PATCH v3 1/6] dt-bindings: crypto: Add X1E80100 Crypto Engine Marcus Glocker
2024-08-16 7:13 ` Krzysztof Kozlowski
2024-08-15 10:39 ` [PATCH v3 2/6] dt-bindings: phy: Add X1E80100 UFS Marcus Glocker
2024-08-16 7:14 ` Krzysztof Kozlowski
2024-08-15 10:41 ` [PATCH v3 3/6] dt-bindings: ufs: " Marcus Glocker
2024-08-16 7:15 ` Krzysztof Kozlowski
2024-08-15 10:42 ` [PATCH v3 4/6] arm64: dts: qcom: Add UFS node Marcus Glocker
2024-08-15 10:47 ` Abel Vesa
2024-08-15 11:54 ` Marcus Glocker
2024-08-15 13:18 ` Abel Vesa
2024-08-15 16:59 ` Marcus Glocker
2024-08-16 7:16 ` Krzysztof Kozlowski
2024-08-16 7:21 ` Krzysztof Kozlowski [this message]
2024-08-15 10:43 ` [PATCH v3 5/6] dt-bindings: arm: Add Samsung Galaxy Book4 Edge Marcus Glocker
2024-08-16 7:17 ` Krzysztof Kozlowski
2024-08-15 10:45 ` [PATCH v3 6/6] arm64: dts: qcom: Add Samsung Galaxy Book4 Edge DTS Marcus Glocker
2024-08-16 7:19 ` Krzysztof Kozlowski
2024-08-16 7:21 ` Krzysztof Kozlowski
2024-08-15 18:28 ` [PATCH v3 0/6] Add initial DTS for Samsung Galaxy Book4 Edge Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70214a1a-82b9-4839-b95b-b75abf467eca@kernel.org \
--to=krzk@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus@nazgul.ch \
--cc=marijn.suijten@somainline.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox