devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Grant Grundler <grundler-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: "t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org"
	<t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	"tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
	<tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"joshi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org"
	<joshi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org"
	<s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	"Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org"
	<Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	"linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"prathyush.k-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org"
	<prathyush.k-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	"sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
	<sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Dave Martin <Dave.Martin-5wv7dgnIgG8@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	"kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org"
	<kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	"a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org"
	<a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>,
	"pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org"
	<pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v12 11/31] documentation: iommu: add binding document of Exynos System MMU
Date: Tue, 29 Apr 2014 23:00:29 +0200	[thread overview]
Message-ID: <7044616.kdaKNu3Qet@wuerfel> (raw)
In-Reply-To: <CANEJEGs6TXNzE8cWYgEKfFSsD2w5XiYvwSbhQ_+gtfzfs+6udA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Tuesday 29 April 2014 13:07:54 Grant Grundler wrote:
> On Tue, Apr 29, 2014 at 11:16 AM, Dave Martin <Dave.Martin-5wv7dgnIgG8@public.gmane.org> wrote:
> ...
> > An IOMMU is really a specialised bridge
> 
> Is a GART a bridge?
> 
> IOMMUs can provide three basic functions:
> 1) remap address space to reach phys mem ranges that the device is
> otherwise not capable of accessing (classic 32-bit DMA to reach 64-bit
> Phys address)
> 
> 2) implement scatter-gather (page level granularity) so the device
> doesn't have to
> 
> 3) provide some level of system protection against "rogue" DMA by
> forcing everything through a DMA mapping interface and faulting when
> encountering unmapped DMA transactions.

[ 4) provide isolation between multiple contexts, typically for purposes
     of virtualization]

> I summarize IOMMUs as: "participate in the routing of MMIO
> transactions in the system fabric."
> In this sense, IOMMUs are sort of a bridge. Defining what kind of
> routing they can do (coalesce transactions? remapping MMIO domains?)
> and which address ranges they route would describe most of that
> functionality.
> 
> This "remapping" of MMIO transaction is also usually asymmetric.
> Meaning routing of "downstream" transactions *might* be completely
> different than the routing + remapping of transactions heading
> upstream. DMA mappings services are designed to handle only the
> transactions generated (aka "mastered") by a downstream device.

For the purposes of the DT binding, we have a 'ranges' property
that defines the downstream translation (CPU-to-MMIO) and a
'dma-ranges' property for the opposite address translation
(device-to-memory).

> >, so it may be cleaner to describe
> > an IOMMU using a real bus node in the DT, if we also define a way to make
> > master/slave linkages explicit where it matters.
> 
> "where it matters" is a bit vague.  Is the goal to just enable DMA
> mapping services to "do the right thing" for a device that can
> generate DMA?

Yes. It's very complicated unfortunately, because we have to be
able to deal with arbitrary combinations of a lot of oddball cases
that can show up in random SoCs:

- device can only do DMA to a limited address range
- DMA is noncoherent and needs manual cache management
- DMA address is at an offset from physical address
- some devices have an IOMMU
- some IOMMUs are shared between devices
- some devices with IOMMU can have multiple simultaneous contexts
- a device may access some memory directly and some other memory through IOMMU
- a device may have DMA access to a bus that is invisible to the CPU
- DMA on some device is only coherent if the IOMMU is enabled
- DMA on some device is only coherent if the IOMMU is disabled
- the IOVA range to an IOMMU is device dependent

> > I've been hacking around some proposals on these areas which are a bit
> > different from the approach suggested here -- I'll try to summarise some
> > of it intelligibly and post something tomorrow so that we can discuss.
> 
> Are you planning on consolidating Documentation/devicetree/bindings/iommu/ ?
> Do you care about Documentation/Intel-IOMMU.txt?

I think we can ignore the Intel-IOMMU because that is specialized on PCI
devices, which we don't normally represent in DT. It is also a special
case because the Intel IOMMU is a single-instance device. If it's present
and enabled, it will be used by every device. The case we do need to describe
is when we don't know which IOMMU is used for which master, or how to
configure it.

	Arnd

  parent reply	other threads:[~2014-04-29 21:00 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-27  7:37 [PATCH v12 00/31] iommu/exynos: Fixes and Enhancements of System MMU driver with DT Shaik Ameer Basha
2014-04-27  7:37 ` [PATCH v12 02/31] iommu/exynos: add missing cache flush for removed page table entries Shaik Ameer Basha
2014-04-27  7:37 ` [PATCH v12 04/31] iommu/exynos: fix L2TLB invalidation Shaik Ameer Basha
2014-04-27  7:37 ` [PATCH v12 06/31] iommu/exynos: allocate lv2 page table from own slab Shaik Ameer Basha
2014-04-27  7:37 ` [PATCH v12 07/31] iommu/exynos: always enable runtime PM Shaik Ameer Basha
2014-04-27  7:37 ` [PATCH v12 08/31] iommu/exynos: handle one instance of sysmmu with a device descriptor Shaik Ameer Basha
2014-04-27  7:37 ` [PATCH v12 10/31] iommu/exynos: use managed device helper functions Shaik Ameer Basha
2014-04-27  7:37 ` [PATCH v12 11/31] documentation: iommu: add binding document of Exynos System MMU Shaik Ameer Basha
2014-04-27 18:23   ` Arnd Bergmann
2014-04-28 10:39     ` Thierry Reding
2014-04-28 10:56       ` Arnd Bergmann
2014-04-28 11:18         ` Thierry Reding
2014-04-28 12:05           ` Arnd Bergmann
2014-04-28 12:49             ` Thierry Reding
2014-04-28 19:30             ` Will Deacon
     [not found]               ` <20140428193056.GD22135-5wv7dgnIgG8@public.gmane.org>
2014-04-28 19:55                 ` Arnd Bergmann
2014-04-29 18:16                   ` Dave Martin
     [not found]                     ` <20140429181601.GE3582-M5GwZQ6tE7x5pKCnmE3YQBJ8xKzm50AiAL8bYrjMMd8@public.gmane.org>
2014-04-29 20:07                       ` Grant Grundler
     [not found]                         ` <CANEJEGs6TXNzE8cWYgEKfFSsD2w5XiYvwSbhQ_+gtfzfs+6udA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-29 21:00                           ` Arnd Bergmann [this message]
2014-04-30 15:14                             ` Dave Martin
2014-05-01 14:02                             ` Cho KyongHo
     [not found]                               ` <20140501230214.ed53cd0fc977225f37b14e29-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-01 14:12                                 ` Arnd Bergmann
2014-05-01 14:50                                 ` Dave Martin
2014-05-01 17:41                             ` Stephen Warren
     [not found]                               ` <53628751.9000609-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-02 11:41                                 ` Dave Martin
2014-04-29 20:46                       ` Arnd Bergmann
2014-05-01 11:15                         ` Dave Martin
     [not found]                           ` <20140501111527.GA3732-M5GwZQ6tE7x5pKCnmE3YQBJ8xKzm50AiAL8bYrjMMd8@public.gmane.org>
2014-05-01 13:29                             ` Arnd Bergmann
2014-05-01 14:36                               ` Dave Martin
     [not found]                                 ` <20140501143654.GB3732-M5GwZQ6tE7x5pKCnmE3YQBJ8xKzm50AiAL8bYrjMMd8@public.gmane.org>
2014-05-01 15:11                                   ` Marc Zyngier
     [not found]                                     ` <53626434.8000807-5wv7dgnIgG8@public.gmane.org>
2014-05-01 15:53                                       ` Arnd Bergmann
2014-05-01 16:24                                         ` Marc Zyngier
2014-05-01 15:46                                   ` Arnd Bergmann
2014-05-01 16:42                               ` Grant Grundler
2014-05-15 20:37             ` Thierry Reding
2014-05-16  0:39               ` Cho KyongHo
2014-04-28 17:52           ` Stephen Warren
2014-04-29  5:55       ` Hiroshi Doyu
2014-04-27  7:37 ` [PATCH v12 12/31] iommu/exynos: support for device tree Shaik Ameer Basha
2014-04-27  7:37 ` [PATCH v12 13/31] iommu/exynos: gating clocks of master H/W Shaik Ameer Basha
2014-04-27  7:37 ` [PATCH v12 15/31] iommu/exynos: handle 'mmu-masters' property of DT and improve handling sysmmu Shaik Ameer Basha
2014-04-27 18:17   ` Arnd Bergmann
2014-05-01 14:08     ` Cho KyongHo
2014-04-27  7:37 ` [PATCH v12 16/31] iommu/exynos: turn on useful configuration options Shaik Ameer Basha
2014-04-27  7:37 ` [PATCH v12 17/31] iommu/exynos: add support for power management subsystems Shaik Ameer Basha
2014-04-27  7:37 ` [PATCH v12 19/31] iommu/exynos: change rwlock to spinlock Shaik Ameer Basha
2014-04-27  7:37 ` [PATCH v12 22/31] iommu/exynos: use exynos-iommu specific typedef Shaik Ameer Basha
2014-04-27  7:37 ` [PATCH v12 23/31] iommu/exynos: use simpler function to get MMU version Shaik Ameer Basha
     [not found] ` <1398584283-22846-1-git-send-email-shaik.ameer-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-04-27  7:37   ` [PATCH v12 01/31] iommu/exynos: do not include removed header Shaik Ameer Basha
2014-04-27  7:37   ` [PATCH v12 03/31] iommu/exynos: change error handling when page table update is failed Shaik Ameer Basha
2014-04-27  7:37   ` [PATCH v12 05/31] iommu/exynos: remove prefetch buffer setting Shaik Ameer Basha
2014-04-27  7:37   ` [PATCH v12 09/31] iommu/exynos: remove dbgname from drvdata of a System MMU Shaik Ameer Basha
2014-04-27  7:37   ` [PATCH v12 14/31] iommu/exynos: remove custom fault handler Shaik Ameer Basha
2014-04-27  7:37   ` [PATCH v12 18/31] iommu/exynos: allow having multiple System MMUs for a master H/W Shaik Ameer Basha
2014-04-28 10:38     ` Tushar Behera
     [not found]       ` <535E2F96.908-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-05-01 14:10         ` Cho KyongHo
2014-05-06 18:05     ` Tomasz Figa
     [not found]       ` <5369245A.1060001-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-05-09 10:54         ` Cho KyongHo
2014-04-27  7:37   ` [PATCH v12 20/31] iommu/exynos: add devices attached to the System MMU to an IOMMU group Shaik Ameer Basha
2014-04-27  7:37   ` [PATCH v12 21/31] iommu/exynos: fix address handling Shaik Ameer Basha
2014-04-27  7:37   ` [PATCH v12 24/31] iommu/exynos: apply workaround of caching fault page table entries Shaik Ameer Basha
2014-04-27  7:37   ` [PATCH v12 25/31] iommu/exynos: enhanced error messages Shaik Ameer Basha
2014-04-27  7:37   ` [PATCH v12 26/31] clk: exynos: add gate clock descriptions of System MMU Shaik Ameer Basha
2014-04-27  7:37   ` [PATCH v12 27/31] ARM: dts: add System MMU nodes of exynos4 series Shaik Ameer Basha
2014-04-27  7:38   ` [PATCH v12 28/31] ARM: dts: add System MMU nodes of exynos4210 Shaik Ameer Basha
2014-04-27  7:38   ` [PATCH v12 29/31] ARM: dts: add System MMU nodes of exynos4x12 Shaik Ameer Basha
2014-04-27  7:38   ` [PATCH v12 30/31] ARM: dts: add System MMU nodes of exynos5250 Shaik Ameer Basha
     [not found]     ` <1398584283-22846-31-git-send-email-shaik.ameer-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-04-27 17:39       ` Vikas Sajjan
2014-04-28 23:13         ` Doug Anderson
     [not found]           ` <CAD=FV=UCpQRg9nWu5EfuzWmBpee9N3X6yCmtpRaNQxitfFZkMQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-01 14:16             ` Cho KyongHo
2014-04-27  7:38   ` [PATCH v12 31/31] ARM: dts: add System MMU nodes of exynos5420 Shaik Ameer Basha
2014-04-28  8:34   ` [PATCH v12 00/31] iommu/exynos: Fixes and Enhancements of System MMU driver with DT Arnd Bergmann
2014-04-30  4:50     ` Shaik Ameer Basha
2014-04-30 10:57     ` Shaik Ameer Basha
2014-05-06 17:59       ` Joerg Roedel
     [not found]         ` <20140506175904.GB12376-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-05-06 18:08           ` Tomasz Figa
     [not found]             ` <5369252F.4070402-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-05-07  0:44               ` Cho KyongHo
2014-05-06 18:21           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7044616.kdaKNu3Qet@wuerfel \
    --to=arnd-r2ngtmty4d4@public.gmane.org \
    --cc=Dave.Martin-5wv7dgnIgG8@public.gmane.org \
    --cc=Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=grundler-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=joshi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=prathyush.k-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    --cc=t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).