From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5EBFC43603 for ; Thu, 19 Dec 2019 13:57:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A33B21D7D for ; Thu, 19 Dec 2019 13:57:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726793AbfLSN5j (ORCPT ); Thu, 19 Dec 2019 08:57:39 -0500 Received: from nbd.name ([46.4.11.11]:36214 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726712AbfLSN5i (ORCPT ); Thu, 19 Dec 2019 08:57:38 -0500 Received: from pd95fd34f.dip0.t-ipconnect.de ([217.95.211.79] helo=[192.168.45.104]) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1ihwJ7-0000kB-At; Thu, 19 Dec 2019 14:57:37 +0100 Subject: Re: [PATCH 1/2] dt: bindings: net: ath11k: add qcom,board_id definition To: Kalle Valo Cc: Rob Herring , devicetree@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org References: <20191217164329.4151-1-john@phrozen.org> <871rt077d8.fsf@kamboji.qca.qualcomm.com> From: John Crispin Message-ID: <7052d9eb-412e-e802-52ed-2e1d63a65fe5@phrozen.org> Date: Thu, 19 Dec 2019 14:57:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <871rt077d8.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/12/2019 14:49, Kalle Valo wrote: > John Crispin writes: > >> We need to be able to define what id the board has allowing us to load the >> correct definition data. This patch adds the description of the required >> property. >> >> Signed-off-by: John Crispin >> --- >> .../devicetree/bindings/net/wireless/qcom,ath11k.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml >> index a1717db36dba..c68daf6ad424 100644 >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml >> @@ -142,6 +142,11 @@ properties: >> * reg >> * reg-names >> >> + qcom,board_id: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + The board id defining what board definition should be loaded > > I think this needs more discussion. This is very tricky to get right, as > it needs to be extensible and what not. With ath10k we have learned that > a simple integer is not enough. > I was expecting this, there seems to be an option to add ranges and/or enums. I did however fail to find any docs on the schemeas. John