From: Philipp Zabel <p.zabel@pengutronix.de>
To: Krzysztof Kozlowski <krzk@kernel.org>, Yao Zi <ziyao@disroot.org>
Cc: Drew Fustini <fustini@kernel.org>, Guo Ren <guoren@kernel.org>,
Fu Wei <wefu@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Michal Wilczynski <m.wilczynski@samsung.com>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Icenowy Zheng <uwu@icenowy.me>,
Han Gao <rabenda.cn@gmail.com>, Han Gao <gaohan@iscas.ac.cn>
Subject: Re: [PATCH 1/4] dt-bindings: reset: thead,th1520-reset: Add controllers for more subsys
Date: Tue, 02 Sep 2025 15:57:02 +0200 [thread overview]
Message-ID: <705de60088f72c1ed575d92e8c4f4b90989385c5.camel@pengutronix.de> (raw)
In-Reply-To: <75cafd7e-02a5-41d1-9daf-24bef20dab82@kernel.org>
On Di, 2025-09-02 at 15:44 +0200, Krzysztof Kozlowski wrote:
> On 02/09/2025 11:04, Yao Zi wrote:
> > On Tue, Sep 02, 2025 at 10:27:53AM +0200, Krzysztof Kozlowski wrote:
> > > On Mon, Sep 01, 2025 at 04:23:17AM +0000, Yao Zi wrote:
> > > > +/* VO Subsystem */
> > > > #define TH1520_RESET_ID_GPU 0
> > > > #define TH1520_RESET_ID_GPU_CLKGEN 1
> > > > -#define TH1520_RESET_ID_NPU 2
> > > > -#define TH1520_RESET_ID_WDT0 3
> > > > -#define TH1520_RESET_ID_WDT1 4
> > >
> > > This is ABI break and deserves explanation and its own patchset.
> >
> > The registers in control of TH1520_RESET_ID_{NPU,WDT0,WDT1} don't belong
> > to the VO reset controller (documented as "thead,th1520-reset"), and
> > thus cannot be implemented by it. They're in fact AP subsystem resets,
> > which gets supported in Linux with this series.
> >
> > Is it okay for you to separate a patch to delete these wrong IDs and add
> > them back for the AP reset controller latter? Anyway, I should have
> > provided more information about these three resets. Thanks for catching
> > this.
>
> So feels like separate patch dropping these resets with above explanation.
They happen to be reintroduced with exactly the same values, just for
the AP subsystem reset controller:
+/* AP Subsystem */
+#define TH1520_RESET_ID_BROM 0
+#define TH1520_RESET_ID_C910_TOP 1
+#define TH1520_RESET_ID_NPU 2
+#define TH1520_RESET_ID_WDT0 3
+#define TH1520_RESET_ID_WDT1 4
[...]
+/* VO Subsystem */
#define TH1520_RESET_ID_GPU 0
#define TH1520_RESET_ID_GPU_CLKGEN 1
-#define TH1520_RESET_ID_NPU 2
-#define TH1520_RESET_ID_WDT0 3
-#define TH1520_RESET_ID_WDT1 4
regards
Philipp
next prev parent reply other threads:[~2025-09-02 13:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 4:23 [PATCH 0/4] Add reset controllers for other TH1520 subsystems Yao Zi
2025-09-01 4:23 ` [PATCH 1/4] dt-bindings: reset: thead,th1520-reset: Add controllers for more subsys Yao Zi
2025-09-02 8:27 ` Krzysztof Kozlowski
2025-09-02 9:04 ` Yao Zi
2025-09-02 13:44 ` Krzysztof Kozlowski
2025-09-02 13:57 ` Philipp Zabel [this message]
2025-09-02 15:43 ` Krzysztof Kozlowski
2025-09-02 13:57 ` Philipp Zabel
2025-09-03 0:41 ` Yao Zi
2025-09-01 4:23 ` [PATCH 2/4] reset: th1520: Prepare for supporting multiple controllers Yao Zi
2025-09-01 4:23 ` [PATCH 3/4] reset: th1520: Support reset controllers in more subsystems Yao Zi
2025-09-02 10:50 ` kernel test robot
2025-09-02 14:15 ` Maud Spierings
2025-09-03 0:44 ` Yao Zi
2025-09-01 4:23 ` [PATCH 4/4] riscv: dts: thead: Add reset controllers of more subsystems for TH1520 Yao Zi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=705de60088f72c1ed575d92e8c4f4b90989385c5.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fustini@kernel.org \
--cc=gaohan@iscas.ac.cn \
--cc=guoren@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=m.wilczynski@samsung.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rabenda.cn@gmail.com \
--cc=robh@kernel.org \
--cc=uwu@icenowy.me \
--cc=wefu@redhat.com \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).