From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Longerbeam Subject: Re: [PATCH] gpio: pca953x: Add optional reset gpio control Date: Tue, 10 Jan 2017 10:57:18 -0800 Message-ID: <70691549-5354-beab-bd87-889e2a627ce6@gmail.com> References: <1483391271-17304-1-git-send-email-steve_longerbeam@mentor.com> <1483391271-17304-2-git-send-email-steve_longerbeam@mentor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Shevchenko Cc: Linus Walleij , Alexandre Courbot , Rob Herring , Mark Rutland , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , devicetree , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Steve Longerbeam List-Id: devicetree@vger.kernel.org On 01/03/2017 03:37 PM, Andy Shevchenko wrote: > On Mon, Jan 2, 2017 at 11:07 PM, Steve Longerbeam wrote: >> Add optional reset-gpios pin control. If present, de-assert the >> specified reset gpio pin to bring the chip out of reset. >> --- a/drivers/gpio/gpio-pca953x.c >> +++ b/drivers/gpio/gpio-pca953x.c >> @@ -22,6 +22,7 @@ >> #include >> #include >> #include >> +#include > Please, try to put it somehow alphabetically ordered (yes, I see it's > not in general, but try to squeeze it into longest part which is > ordered). done. > >> #define PCA953X_INPUT 0 >> #define PCA953X_OUTPUT 1 >> @@ -754,8 +755,18 @@ static int pca953x_probe(struct i2c_client *client, >> invert = pdata->invert; >> chip->names = pdata->names; >> } else { >> + struct gpio_desc *reset_gpio; >> + >> chip->gpio_start = -1; >> irq_base = 0; >> + >> + /* see if we need to de-assert a reset pin */ > see -> See done. Steve -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html