From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexey Klimov <alexey.klimov@linaro.org>,
sre@kernel.org, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, peter.griffin@linaro.org,
robh+dt@kernel.org
Cc: conor+dt@kernel.org, linux-samsung-soc@vger.kernel.org,
semen.protsenko@linaro.org, linux-kernel@vger.kernel.org,
klimov.linux@gmail.com, kernel-team@android.com,
tudor.ambarus@linaro.org, andre.draszik@linaro.org,
saravanak@google.com, willmcvicker@google.com,
alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org,
elder@linaro.org
Subject: Re: [PATCH 2/3] arm64: dts: exynos: gs101: add poweroff node
Date: Wed, 20 Mar 2024 08:15:41 +0100 [thread overview]
Message-ID: <70846fbb-9c17-440a-911d-456b0444dd94@linaro.org> (raw)
In-Reply-To: <20240320020549.71810-2-alexey.klimov@linaro.org>
On 20/03/2024 03:05, Alexey Klimov wrote:
> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
> ---
> arch/arm64/boot/dts/exynos/google/gs101.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> index 55e6bcb3689e..9def28393274 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> @@ -509,6 +509,13 @@ sysreg_apm: syscon@174204e0 {
> pmu_system_controller: system-controller@17460000 {
> compatible = "google,gs101-pmu", "syscon";
> reg = <0x17460000 0x10000>;
> +
> + poweroff {
> + compatible = "google,gs101-poweroff";
> + samsung,syscon-phandle = <&pmu_system_controller>;
This is just senseless... you are the child of pmu, as seen in this DTS.
You do not need to reference yourself (so the PMU)!
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-20 7:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 2:05 [PATCH 1/3] dt-bindings: power: reset: add gs101 poweroff bindings Alexey Klimov
2024-03-20 2:05 ` [PATCH 2/3] arm64: dts: exynos: gs101: add poweroff node Alexey Klimov
2024-03-20 7:15 ` Krzysztof Kozlowski [this message]
2024-03-20 2:05 ` [PATCH 3/3] power: reset: add new gs101-poweroff driver Alexey Klimov
2024-03-20 7:20 ` Krzysztof Kozlowski
2024-03-22 12:25 ` Peter Griffin
2024-03-25 19:13 ` Krzysztof Kozlowski
2024-03-20 7:14 ` [PATCH 1/3] dt-bindings: power: reset: add gs101 poweroff bindings Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70846fbb-9c17-440a-911d-456b0444dd94@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexey.klimov@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@linaro.org \
--cc=kernel-team@android.com \
--cc=klimov.linux@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=semen.protsenko@linaro.org \
--cc=sre@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox