From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f49.google.com ([209.85.214.49]:37575 "EHLO mail-bk0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755517Ab3HWTsl (ORCPT ); Fri, 23 Aug 2013 15:48:41 -0400 From: Tomasz Figa Subject: Re: [PATCH v4 4/7] ARM: dts: add dt nodes for exynos5420 hdmi subsystem Date: Fri, 23 Aug 2013 21:48:34 +0200 Message-ID: <7099911.E9MGK44AOv@flatron> In-Reply-To: <1377253461-20851-5-git-send-email-rahul.sharma@samsung.com> References: <1377253461-20851-1-git-send-email-rahul.sharma@samsung.com> <1377253461-20851-5-git-send-email-rahul.sharma@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: devicetree-owner@vger.kernel.org To: Rahul Sharma Cc: linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, kgene.kim@samsung.com, sw0312.kim@samsung.com, inki.dae@samsung.com, s.nawrocki@samsung.com, joshi@samsung.com, r.sh.open@gmail.com List-ID: Hi Rahul, Please see my comments inline. On Friday 23 of August 2013 15:54:18 Rahul Sharma wrote: > Add hdmi, mixer, ddc device tree nodes for Exynos 5420 SoC. > > Signed-off-by: Rahul Sharma > --- > arch/arm/boot/dts/exynos5420-smdk5420.dts | 19 +++++++++++++++++++ > arch/arm/boot/dts/exynos5420.dtsi | 14 ++++++++++++++ > 2 files changed, 33 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts > b/arch/arm/boot/dts/exynos5420-smdk5420.dts index bafba25..7dbf1fa > 100644 > --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts > +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts > @@ -61,4 +61,23 @@ > }; > }; > > + hdmi@14530000 { > + status = "okay"; > + hpd-gpio = <&gpx3 7 0>; > + }; > + > + mixer@14450000 { > + status = "okay"; > + }; > + > + i2c_2: i2c@12C80000 { > + samsung,i2c-sda-delay = <100>; > + samsung,i2c-max-bus-freq = <66000>; > + status = "okay"; > + > + hdmiddc@50 { > + compatible = "samsung,exynos4210-hdmiddc"; > + reg = <0x50>; > + }; > + }; > }; You should separate above board-specific changes from this patch and squash it with patch 6/7, adjusting patch subject and description appropriately. > diff --git a/arch/arm/boot/dts/exynos5420.dtsi > b/arch/arm/boot/dts/exynos5420.dtsi index 05dee86..7c6214d 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -274,4 +274,18 @@ > pinctrl-0 = <&i2c3_bus>; > status = "disabled"; > }; > + > + hdmi@14530000 { > + compatible = "samsung,exynos4212-hdmi"; > + reg = <0x14530000 0x70000>; > + interrupts = <0 95 0>; > + status = "disabled"; > + }; > + > + mixer@14450000 { > + compatible = "samsung,exynos5420-mixer"; > + reg = <0x14450000 0x10000>; > + interrupts = <0 94 0>; > + status = "disabled"; This node looks like a candidate to be enabled here on SoC level, since it does not require any board specific information. Best regards, Tomasz