From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83FCAC001B0 for ; Mon, 24 Jul 2023 07:04:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230143AbjGXHEn (ORCPT ); Mon, 24 Jul 2023 03:04:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjGXHEm (ORCPT ); Mon, 24 Jul 2023 03:04:42 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 182D3134 for ; Mon, 24 Jul 2023 00:04:40 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-51e28cac164so10481121a12.1 for ; Mon, 24 Jul 2023 00:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690182278; x=1690787078; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BnI7Q+4yw6+Z1QsdbFCjMZJuIk0S1yM6lQ+dTWG+bVY=; b=oFRBRV+e8Y/1GMGUalQeZ8ynScg1pxsFkjUl1Id0XqRLT9gzB1JUMgrzDpIBzhr9uK Ie7LEBjLzgAEz3u5KlizMJNhKWyIesAU8u5JO3iCWSIaJv2sHsA0RDYr3O2IZf1c/L6O gb+dUsj/Mt+25J4FLZxLNvECG6LUJN1cwl0ZLANi90v2YW+0yypreCt66Ih4P3LEEl8w FHahHHJ3r6hJzBFrhs97btXxpeOC3ByTuK2xETtWYywjFHXJ1v6Mj25nw6K2hYKiJ7Ci wRohVY3Eh/9V6BYEQGhwjOKW3f3OVfKZk8VfkJLrlRh0oc3nAxCaIdrXNwOh1kEDANx2 sumg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690182278; x=1690787078; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BnI7Q+4yw6+Z1QsdbFCjMZJuIk0S1yM6lQ+dTWG+bVY=; b=d1bTfNr9FIeKSsMFJT4hXatgxjApUi1g2BYb88SirwVuXNXuKBCj/wxGINLpN4aMSs BATIO2SxC197wMjsld/YR/ImSdVdol+BGJPJkmccrwQSMbcCCXLJdFazcSIaeZEUgtCf zgGaO423BU3xbqN7ZqfV2NaT6O7mRg19QkEID7cFHTkne0DYacI7T3+5j1FNdGN7TKNl LIheuwQaJH3c9xknnzNohgEfYTmsaWyUrMHqRumML11KklksofTOLhmNvm9cHXBzbAtu H2oCimrDmf1nqMpNGf9srq6gqZnrGKF4E/tZkqsCbp62b04LPua6lPSD/hhPV05gDfVk lNVQ== X-Gm-Message-State: ABy/qLbQz1gYPUiUvrRdLu4wdZrCkS4SJFAuobLpkOWdDvsSrDw9h2yb VifDiH7TRoXBz8IZzi05Zvg52Q== X-Google-Smtp-Source: APBJJlEr9XbF2zEoV+DCoZBAEmLbxcPrw/9GpNugz7ENquW1MAgvZ4niHKqwkUjGuLAYUZXNkEqdzQ== X-Received: by 2002:a17:906:1090:b0:997:e9a3:9c4f with SMTP id u16-20020a170906109000b00997e9a39c4fmr8787535eju.30.1690182278467; Mon, 24 Jul 2023 00:04:38 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id bt16-20020a170906b15000b00993159ce075sm6209126ejb.210.2023.07.24.00.04.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jul 2023 00:04:37 -0700 (PDT) Message-ID: <70a823a4-54d1-18a3-3d77-45564d88e8f1@linaro.org> Date: Mon, 24 Jul 2023 09:04:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/2] dt-bindings: usb: Add Intel SoCFPGA USB controller Content-Language: en-US To: adrian.ho.yin.ng@intel.com, gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, Thinh.Nguyen@synopsys.com, p.zabel@pengutronix.de References: <0d12c7a196d6ad81cfc69b281dd1c4cca623d9bd.1690179693.git.adrian.ho.yin.ng@intel.com> From: Krzysztof Kozlowski In-Reply-To: <0d12c7a196d6ad81cfc69b281dd1c4cca623d9bd.1690179693.git.adrian.ho.yin.ng@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/07/2023 08:36, adrian.ho.yin.ng@intel.com wrote: > From: Adrian Ng Ho Yin > > Existing binding intel,keembay-dwc3.yaml does not have the required > properties for Intel SoCFPGA devices. > Introduce new binding description for Intel SoCFPGA USB controller > which will be used for current and future SoCFPGA devices. > > Signed-off-by: Adrian Ng Ho Yin > --- > .../bindings/usb/intel,socfpga-dwc3.yaml | 84 +++++++++++++++++++ > 1 file changed, 84 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/intel,socfpga-dwc3.yaml > > diff --git a/Documentation/devicetree/bindings/usb/intel,socfpga-dwc3.yaml b/Documentation/devicetree/bindings/usb/intel,socfpga-dwc3.yaml > new file mode 100644 > index 000000000000..e36b087c2651 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/intel,socfpga-dwc3.yaml > @@ -0,0 +1,84 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/intel,socfpga-dwc3.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Intel SoCFPGA DWC3 USB controller > + > +maintainers: > + - Adrian Ng Ho Yin > + > +properties: > + compatible: > + items: > + - enum: > + - intel,agilex5-dwc3 > + - const: intel,socfpga-dwc3 So you did not even wait for my answer? What happened here with this compatible? I asked you to change file name, not add intel,socfpga-dwc3. Again - why using different style for Agilex? Which style is correct? > + > + reg: > + description: Offset and length of DWC3 controller register What happened here? It wasn't here before. > + maxItems: 1 > + > + clocks: > + items: > + - description: Controller Master/Core clock > + - description: Controller Suspend clock > + > + ranges: true > + > + resets: > + description: A list of phandles for resets listed in reset-names Neither was this useless description, it is obvious. > + maxItems: 2 > + > + reset-names: > + items: > + - const: dwc3 > + - const: dwc3-ecc > + > + '#address-cells': > + enum: [ 1, 2 ] > + > + '#size-cells': > + enum: [ 1, 2 ] > + > +# Required child node: > + > +patternProperties: > + "^usb@[0-9a-f]+$": > + $ref: snps,dwc3.yaml# > + > +required: > + - compatible > + - reg > + - clocks > + - resets > + - ranges > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + usb@11000000 { > + compatible = "intel,agilex5-dwc3", "intel,socfpga-dwc3"; Still wrong indentation.... > + reg = <0x11000000 0x100000>; > + ranges; > + clocks = <&clkmgr 54>, > + <&clkmgr 55>; > + resets = <&rst USB0_RESET>, <&rst USB1_RESET>; > + reset-names = "dwc3", "dwc3-ecc"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + usb@11000000 { > + compatible = "snps,dwc3"; > + reg = <0x11000000 0x100000>; > + interrupts = ; > + dr_mode = "host"; > + }; > + }; > + Drop trailing line. Instead of resending just after your reply, allow for reviewer to respond. Best regards, Krzysztof