Re: [PATCH 1/5] arm64: dts: qcom: msm8917-xiaomi-riva: Commonize for Redmi 4A and GO

[barnabas.czeman@mainlining.org]

On 2026-03-10 14:21, Konrad Dybcio wrote:
> On 3/10/26 2:11 PM, barnabas.czeman@mainlining.org wrote:
>> On 2026-03-10 14:04, Konrad Dybcio wrote:
>>> On 3/10/26 1:57 PM, barnabas.czeman@mainlining.org wrote:
>>>> On 2026-03-09 13:55, Konrad Dybcio wrote:
>>>>> On 3/5/26 6:28 PM, Barnabás Czémán wrote:
>>>>>> Redmi 5A is very similar for Redmi 4A (rolex) and Redmi GO 
>>>>>> (tiare),
>>>>>> it can be commonized for avoid unnecessary code duplications.
>>>>>> 
>>>>>> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
>>>>>> ---
>>>>> 
>>>>> Could you please try adding the following to your gitconfig:
>>>>> 
>>>>> [diff]
>>>>>         renameLimit = 999999
>>>>>         algorithm = histogram # or 'copies'
>>>>>         renames = copies
>>>>> 
>>>>> and see if this generates a shorter diff?
>>>>> 
>>>>> Konrad
>>>> One more question should i rename msm8917-xiaomi-riva-common to 
>>>> msm8917-wingtech-common,
>>>> they are wingtech devices. Which naming is preferred?
>>> 
>>> I think xiaomi-riva is easier for people to associate with a phone
>>> they may have in their drawer than wingtech-s88503
>> What about renaming just the common part to msm8917-wingtech-common?
> 
> I think it adds more confusion without much benefit. Probably none
> of these devices have been released without a Mi logo on the back.
Yes but riva codename is related to Redmi 5A and naming as 
msm8917-xiaomi-common
could cause confusion later when i would send Redmi Note 5A (ugglite) 
what is
none wingtech device and have much more difference.
> 
> Konrad