From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.mainlining.org (mail.mainlining.org [5.75.144.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14357391E5C; Tue, 10 Mar 2026 13:26:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.75.144.95 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773149201; cv=none; b=fKZpAOmuExgEdCE5jYXZPO383og7m8FmNZJXVqzumJ6KL0RfAL0AgJHtzC9LMNzOcLBFWfgJ0gW93MZAgrVsHp70eXEvsfy2PCUYsxpphsThVVAnh/Ak/hTcDAsrTN/IScF0g7Q99Gp23ETqb0Yns61y+4C0ZFVBiwhSI2k0ZyI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773149201; c=relaxed/simple; bh=IMnuUP1mDDDVn8cmGiep4hQ//yzXqOeQPK9cjdkRnks=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=sCl6MIuXKjY9+vr3LDi3gF5YgxvbSMo9VKcKoA4QMzVRN565erw1DgUxy14ik4YIlR+4rBmk30dvxJ7PSoPj4vgHiHXZm1L8Nbi4MLl0EUxOU3zexaLGyyFB8Das906QDGJvII3Vuf00+lq/xLeJJedxoudS9qcJ4BeXzoK2JGE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mainlining.org; spf=pass smtp.mailfrom=mainlining.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b=aeYD1Zfr; dkim=permerror (0-bit key) header.d=mainlining.org header.i=@mainlining.org header.b=zuprYGBe; arc=none smtp.client-ip=5.75.144.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mainlining.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mainlining.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b="aeYD1Zfr"; dkim=permerror (0-bit key) header.d=mainlining.org header.i=@mainlining.org header.b="zuprYGBe" DKIM-Signature: v=1; a=rsa-sha256; s=202507r; d=mainlining.org; c=relaxed/relaxed; h=Message-ID:Subject:To:From:Date; t=1773149193; bh=Yefgatn7L7v/FCptUmJOo7I 3XLKjozge7Yu8hNJc2GQ=; b=aeYD1ZfrFOCu2edOXHXpIxkxN68EMutaIgefMyqgRhanF9rPpw Y5F8jMARaRtH6g6CvCDBZx10NpOpWCn311+s5ubFGIdB1f5m2FSFZJiAlbQrEj+Bg314+Tce0K2 7CejDJr4lcZgRFUfH2wS6sTGf+jiMBpskER/HJ7p01uoXGZXhHhvOK9WcIltJo1LdMHM4tS3JTs 5uCtLyehS/fHGwQltdtsJeGDwhUeDZ3nWSjTJI6ldUwAaYkLHgRv2XoUfxVl/7x++ZccAHYCbBT R4M5ZaRyRjYb8nUyr/pLhv/V3DmCiV9z0Ddy3aYcolMAqmPRROCcUZ4/tqsYJLtnp5w==; DKIM-Signature: v=1; a=ed25519-sha256; s=202507e; d=mainlining.org; c=relaxed/relaxed; h=Message-ID:Subject:To:From:Date; t=1773149193; bh=Yefgatn7L7v/FCptUmJOo7I 3XLKjozge7Yu8hNJc2GQ=; b=zuprYGBev3oyvViHXnpIrT5b/5hqH1e6Jau22VU9CkGeZRJka6 kCow6AC76EkVNKwVYibRlkKE8lTQU1PjBxAQ==; Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 10 Mar 2026 14:26:33 +0100 From: barnabas.czeman@mainlining.org To: Konrad Dybcio Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org, phone-devel@vger.kernel.org Subject: Re: [PATCH 1/5] arm64: dts: qcom: msm8917-xiaomi-riva: Commonize for Redmi 4A and GO In-Reply-To: References: <20260305-riva-common-v1-0-436f1f4b7399@mainlining.org> <20260305-riva-common-v1-1-436f1f4b7399@mainlining.org> <2255b753-4d40-4e49-a89c-22ee939c51d1@oss.qualcomm.com> <6665244d82ee8776826a7f6a4e64af99@mainlining.org> Message-ID: <70ad0b19dbeee89c04c17a0618a9cecc@mainlining.org> X-Sender: barnabas.czeman@mainlining.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2026-03-10 14:21, Konrad Dybcio wrote: > On 3/10/26 2:11 PM, barnabas.czeman@mainlining.org wrote: >> On 2026-03-10 14:04, Konrad Dybcio wrote: >>> On 3/10/26 1:57 PM, barnabas.czeman@mainlining.org wrote: >>>> On 2026-03-09 13:55, Konrad Dybcio wrote: >>>>> On 3/5/26 6:28 PM, Barnabás Czémán wrote: >>>>>> Redmi 5A is very similar for Redmi 4A (rolex) and Redmi GO >>>>>> (tiare), >>>>>> it can be commonized for avoid unnecessary code duplications. >>>>>> >>>>>> Signed-off-by: Barnabás Czémán >>>>>> --- >>>>> >>>>> Could you please try adding the following to your gitconfig: >>>>> >>>>> [diff] >>>>>         renameLimit = 999999 >>>>>         algorithm = histogram # or 'copies' >>>>>         renames = copies >>>>> >>>>> and see if this generates a shorter diff? >>>>> >>>>> Konrad >>>> One more question should i rename msm8917-xiaomi-riva-common to >>>> msm8917-wingtech-common, >>>> they are wingtech devices. Which naming is preferred? >>> >>> I think xiaomi-riva is easier for people to associate with a phone >>> they may have in their drawer than wingtech-s88503 >> What about renaming just the common part to msm8917-wingtech-common? > > I think it adds more confusion without much benefit. Probably none > of these devices have been released without a Mi logo on the back. Yes but riva codename is related to Redmi 5A and naming as msm8917-xiaomi-common could cause confusion later when i would send Redmi Note 5A (ugglite) what is none wingtech device and have much more difference. > > Konrad