From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75EA6C77B73 for ; Tue, 2 May 2023 12:50:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233856AbjEBMuA (ORCPT ); Tue, 2 May 2023 08:50:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234305AbjEBMt6 (ORCPT ); Tue, 2 May 2023 08:49:58 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6C3D5252; Tue, 2 May 2023 05:49:52 -0700 (PDT) Received: from [192.168.1.90] (unknown [188.27.34.213]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id 837F46602121; Tue, 2 May 2023 13:49:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1683031791; bh=1SBHvxpiiP3vO8FDcUxSdgWcAeK19kTJhEfXoSg3Bz8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lVX3TX5nOP8T7DAc8DnTniZmRwQkSATanSOambI0L6/HJZCEogsIFtChW2g8t24bU 8KHdn8iVUlYv9kBuDsz0gI1UzjMBwHtUsvO+mhG5O+5g+aZnJNXJssb6WiPYtN47Rm f0jJjslUabz66qmeaGQgvzakgmbGyIq+tRd2BTaaaV2Pb/jynGbtfzOQm7bCV9mZMh /sDwpb07Ht05krpJVuU8BW4Jyk4Pey1OoFD/dDTVyefXM+0xA3Ehq4FG484w3MlLxj cGWVHbZh+SvUHODfwkwJbGf2nvOORl6R+nVjv54/gBNzHRTDpawHaL6KKRponweb6J Sm9+7MvfEGnAg== Message-ID: <70d71afc-5191-2995-9975-7a2871c226aa@collabora.com> Date: Tue, 2 May 2023 15:49:47 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 3/8] nvmem: rockchip-otp: Add clocks and reg_read to rockchip_data Content-Language: en-US To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Philipp Zabel , Sebastian Reichel , Shreeya Patel , Kever Yang , Finley Xiao Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20230501084401.765169-1-cristian.ciocaltea@collabora.com> <20230501084401.765169-4-cristian.ciocaltea@collabora.com> <6064284.AJdgDx1Vlc@diego> From: Cristian Ciocaltea In-Reply-To: <6064284.AJdgDx1Vlc@diego> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 5/2/23 11:47, Heiko Stübner wrote: > Am Montag, 1. Mai 2023, 10:43:55 CEST schrieb Cristian Ciocaltea: >> In preparation to support new Rockchip OTP memory devices with different >> clock configurations and register layout, extend rockchip_data struct >> with the related members: clocks, num_clks, reg_read. >> >> Additionally, to avoid managing redundant driver data, drop num_clks >> member from rockchip_otp struct and update all references to point to >> the equivalent member in rockchip_data. >> >> Signed-off-by: Cristian Ciocaltea >> --- >> drivers/nvmem/rockchip-otp.c | 79 ++++++++++++++++++++++-------------- >> 1 file changed, 49 insertions(+), 30 deletions(-) >> >> diff --git a/drivers/nvmem/rockchip-otp.c b/drivers/nvmem/rockchip-otp.c >> index 9f53bcce2f87..a5b234e60735 100644 >> --- a/drivers/nvmem/rockchip-otp.c >> +++ b/drivers/nvmem/rockchip-otp.c >> @@ -54,21 +54,19 @@ >> >> #define OTPC_TIMEOUT 10000 >> >> +struct rockchip_data { >> + int size; >> + const char * const *clocks; >> + int num_clks; > > nit: might be nice to use either "clocks" or "clks" as part for both names Indeed, will handle this in v2. > other than that > Reviewed-by: Heiko Stuebner Thanks, Cristian