From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Daniel Baluta" <daniel.baluta@gmail.com>,
"Javier García" <javier.garcia.ta@udima.es>
Cc: daniel.baluta@nxp.com, broonie@kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Damien.Horsley" <Damien.Horsley@imgtec.com>
Subject: Re: [PATCH v2] ASoC: dt-bindings: img,spdif-in: Convert to dtschema
Date: Wed, 28 Feb 2024 08:40:39 +0100 [thread overview]
Message-ID: <7107d732-6bee-4c28-b317-c7a3adb909bd@linaro.org> (raw)
In-Reply-To: <CAEnQRZAvqHfNYu+dYObJA=T7S_KfQMxB8TJGmdjK9Ea_FPrLOA@mail.gmail.com>
On 27/02/2024 17:29, Daniel Baluta wrote:
> On Tue, Feb 27, 2024 at 6:27 PM Daniel Baluta <daniel.baluta@gmail.com> wrote:
>>
>> This looks much better than v1. Make sure you have addressed all
>> comments from the previous version
>> and add a short log under the scissor line explaining what you have changed.
>>
>> Few comments inline:
>>
>>
>> On Tue, Feb 27, 2024 at 6:13 PM Javier García <javier.garcia.ta@udima.es> wrote:
>>>
>>> Convert the Imagination Technologies SPDIF Input Controllerto DT schema.
>>>
>>> Signed-off-by: Javier García <javier.garcia.ta@udima.es>
>>> ---
>> ^ this is the scissor line. Here you add the change log.
>>
>> Changes since v1:
>> - re-written the subject inline to include relevant prefix
>> - removed header file as it is not used
>> - ....etc
>>
>>
>>> +$id: http://devicetree.org/schemas/sound/img,spdif-in.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Imagination Technologies SPDIF Input Controller
>>> +
>>> +maintainers:
>>> + - Liam Girdwood <lgirdwood@gmail.com>
>>> + - Mark Brown <broonie@kernel.org>
>>
>> Please do not blindly add people here. The most proper candidate for this
>> is the people who wrote the original file.
>>
>> Using git log we can find Damien.Horsley <Damien.Horsley@imgtec.com>
>
> Looks like this address bounced back.
>
> @Krzysztof Kozlowski @Mark Brown is it OK to add a mailing list as
> maintainer for a yml file?
Yeah, works as a last resort, when we cannot find any responsible person.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-28 7:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 12:35 [PATCH] Convert the Imagination Technologies SPDIF Input Controllerto DT schema Javier García
2024-02-27 12:54 ` Daniel Baluta
2024-02-27 12:56 ` Mark Brown
2024-02-27 13:28 ` Krzysztof Kozlowski
2024-02-27 16:09 ` [PATCH v2] ASoC: dt-bindings: img,spdif-in: Convert to dtschema Javier García
2024-02-27 16:27 ` Daniel Baluta
2024-02-27 16:29 ` Daniel Baluta
2024-02-28 7:40 ` Krzysztof Kozlowski [this message]
2024-02-27 17:03 ` [PATCH v3] " Javier García
2024-02-28 7:38 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7107d732-6bee-4c28-b317-c7a3adb909bd@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Damien.Horsley@imgtec.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=javier.garcia.ta@udima.es \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).