Re: [PATCH 1/2] dt-bindings: input: touchscreen: goodix: Add no-reset-pull-up property

[Krzysztof Kozlowski <krzk@kernel.org>]

On 28/04/2025 09:58, Esben Haabendal wrote:
> On Monday, April 28th, 2025 at 09:48, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On Tue, Apr 22, 2025 at 05:15:02PM GMT, Esben Haabendal wrote:
>>
>>> This should be added for boards where there is no pull-up on the reset pin,
>>> as the driver will otherwise switch the reset signal to high-impedance to
>>> save power, which obviously not safe without pull-up.
>>>
>>> Signed-off-by: Esben Haabendal esben@geanix.com
>>> ---
>>> Documentation/devicetree/bindings/input/touchscreen/goodix.yaml | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
>>> index eb4992f708b70fef93bd4b59b9565123f7c6ad5d..7e5c4b98f2cb1ef61798252ea5c573068a46d4aa 100644
>>> --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
>>> +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
>>> @@ -45,6 +45,10 @@ properties:
>>> reset-gpios:
>>> maxItems: 1
>>>
>>> + no-reset-pull-up:
>>
>> Is this common property? Where is it defined? Otherwise missing vendor
>> prefix.
> 
> Good question. When is something a common property?

When is defined in common schema and used by more than 2 devices.

> 
> The idea of marking something as not having a pull-up on the reset pin could be considered a common thing I guess.
> But for now, I am defining it for the goodix driver only, as I am only aware of these devices needing to handle it in a special way.
> 
> Should I rename it to goodix,no-reset-pull-up?


Yes


Best regards,
Krzysztof