From: "Heiko Stübner" <heiko@sntech.de>
To: agajjar <Akash_Gajjar@mentor.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Oskari Lemmela <oskari@lemmela.net>,
Shohei Maruyama <cheat.sc.linux@outlook.com>,
Levin Du <djw@t-chip.com.cn>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] arm64: dts: rockchip: rockpro64 dts remove unused node
Date: Fri, 15 Feb 2019 21:46:03 +0100 [thread overview]
Message-ID: <7155828.jr86DZMtXN@diego> (raw)
In-Reply-To: <ac22440d-3b64-1cf2-205c-52ea7c1c23f9@mentor.com>
Am Freitag, 15. Februar 2019, 13:08:16 CET schrieb agajjar:
> On 2/15/2019 2:48 PM, Heiko Stübner wrote:
> > Am Mittwoch, 13. Februar 2019, 18:06:38 CET schrieb Akash Gajjar:
> >> lcd panel pinmux and vcc1v8_s3 regulator is redundant and has a no
> >> impact,
> >> so removing it.
> >>
> >> Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com>
>
> Hi Heiko,
>
> > vcc1v8_s3 is actually also a emmc supply, so I'd like to keep it around
> > for completenes sake.
>
> Emmc module is supplied by PMIC vcc3v3_s3 (SWITCH_REG1) and vcc_1v8
> (DCD_REG4).
>
> So I believe removing vcc1v8_s3 has no impact on emmc supply line.
looking at the rockpro64 schematics page 10, I see vcca1v8_s3 linked
to the emmc_vdd_1v8 input and obviously also as reference for the saradc.
So I think we really could keep it around, so that the power-tree resembles
the schematics more.
next prev parent reply other threads:[~2019-02-15 20:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 17:06 [PATCH 0/4] arm64: dts: rockchip: rk3399-rockpro64 dts cleanup Akash Gajjar
2019-02-13 17:06 ` [PATCH 1/4] arm64: dts: rockchip: rockpro64 dts make regulator more readable Akash Gajjar
2019-02-15 9:14 ` Heiko Stübner
2019-02-13 17:06 ` [PATCH 2/4] arm64: dts: rockchip: rockpro64 dts remove unused node Akash Gajjar
2019-02-15 9:18 ` Heiko Stübner
2019-02-15 12:08 ` agajjar
2019-02-15 20:46 ` Heiko Stübner [this message]
2019-02-16 15:20 ` agajjar
2019-02-13 17:06 ` [PATCH 3/4] arm64: dts: rockchip: rockpro64 dts rename LED labels and default trigger Akash Gajjar
2019-02-15 9:21 ` Heiko Stübner
2019-02-13 17:06 ` [PATCH 4/4] arm64: dts: rockchip: rockpro64 dts add usb regulator Akash Gajjar
2019-02-15 9:24 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7155828.jr86DZMtXN@diego \
--to=heiko@sntech.de \
--cc=Akash_Gajjar@mentor.com \
--cc=cheat.sc.linux@outlook.com \
--cc=devicetree@vger.kernel.org \
--cc=djw@t-chip.com.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=oskari@lemmela.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).