devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] dt-bindings: serial: imx: Document optional DMA properties
@ 2023-02-19 14:22 Marek Vasut
  2023-02-19 14:22 ` [PATCH v2 2/2] dt-bindings: serial: imx: Document mandatory clock properties Marek Vasut
  0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2023-02-19 14:22 UTC (permalink / raw)
  To: devicetree
  Cc: Marek Vasut, Krzysztof Kozlowski, Fabio Estevam,
	Greg Kroah-Hartman, Krzysztof Kozlowski, NXP Linux Team,
	Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo,
	linux-arm-kernel, linux-serial

The UART IP can be connected to DMA engine, document the properties in DT bindings.
Update example to match Linux arch/arm/boot/dts/imx51.dtsi .

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-serial@vger.kernel.org
---
V2: Add AB from Krzysztof
---
 .../devicetree/bindings/serial/fsl-imx-uart.yaml     | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml b/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
index 4cbe76e1715b7..c22aab8c55f83 100644
--- a/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
@@ -49,6 +49,16 @@ properties:
   reg:
     maxItems: 1
 
+  dmas:
+    items:
+      - description: DMA controller phandle and request line for RX
+      - description: DMA controller phandle and request line for TX
+
+  dma-names:
+    items:
+      - const: rx
+      - const: tx
+
   interrupts:
     maxItems: 1
 
@@ -100,6 +110,8 @@ examples:
         compatible = "fsl,imx51-uart", "fsl,imx21-uart";
         reg = <0x73fbc000 0x4000>;
         interrupts = <31>;
+        dmas = <&sdma 18 4 1>, <&sdma 19 4 2>;
+        dma-names = "rx", "tx";
         uart-has-rtscts;
         fsl,dte-mode;
     };
-- 
2.39.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v2 2/2] dt-bindings: serial: imx: Document mandatory clock properties
  2023-02-19 14:22 [PATCH v2 1/2] dt-bindings: serial: imx: Document optional DMA properties Marek Vasut
@ 2023-02-19 14:22 ` Marek Vasut
  2023-02-20  7:48   ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2023-02-19 14:22 UTC (permalink / raw)
  To: devicetree
  Cc: Marek Vasut, Fabio Estevam, Greg Kroah-Hartman,
	Krzysztof Kozlowski, NXP Linux Team, Pengutronix Kernel Team,
	Rob Herring, Sascha Hauer, Shawn Guo, linux-arm-kernel,
	linux-serial

The UART IP must be connected to clock, document the properties in DT bindings.
Update example to match Linux arch/arm/boot/dts/imx51.dtsi .

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-serial@vger.kernel.org
---
V2: Drop the assigned-clock-*
---
 .../devicetree/bindings/serial/fsl-imx-uart.yaml  | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml b/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
index c22aab8c55f83..40414247d61a3 100644
--- a/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
@@ -49,6 +49,14 @@ properties:
   reg:
     maxItems: 1
 
+  clocks:
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: ipg
+      - const: per
+
   dmas:
     items:
       - description: DMA controller phandle and request line for RX
@@ -96,12 +104,16 @@ properties:
 required:
   - compatible
   - reg
+  - clocks
+  - clock-names
   - interrupts
 
 unevaluatedProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/imx5-clock.h>
+
     aliases {
         serial0 = &uart1;
     };
@@ -110,6 +122,9 @@ examples:
         compatible = "fsl,imx51-uart", "fsl,imx21-uart";
         reg = <0x73fbc000 0x4000>;
         interrupts = <31>;
+        clocks = <&clks IMX5_CLK_UART1_IPG_GATE>,
+                 <&clks IMX5_CLK_UART1_PER_GATE>;
+        clock-names = "ipg", "per";
         dmas = <&sdma 18 4 1>, <&sdma 19 4 2>;
         dma-names = "rx", "tx";
         uart-has-rtscts;
-- 
2.39.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 2/2] dt-bindings: serial: imx: Document mandatory clock properties
  2023-02-19 14:22 ` [PATCH v2 2/2] dt-bindings: serial: imx: Document mandatory clock properties Marek Vasut
@ 2023-02-20  7:48   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-20  7:48 UTC (permalink / raw)
  To: Marek Vasut, devicetree
  Cc: Fabio Estevam, Greg Kroah-Hartman, Krzysztof Kozlowski,
	NXP Linux Team, Pengutronix Kernel Team, Rob Herring,
	Sascha Hauer, Shawn Guo, linux-arm-kernel, linux-serial

On 19/02/2023 15:22, Marek Vasut wrote:
> The UART IP must be connected to clock, document the properties in DT bindings.
> Update example to match Linux arch/arm/boot/dts/imx51.dtsi .
> 


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-02-20  7:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-19 14:22 [PATCH v2 1/2] dt-bindings: serial: imx: Document optional DMA properties Marek Vasut
2023-02-19 14:22 ` [PATCH v2 2/2] dt-bindings: serial: imx: Document mandatory clock properties Marek Vasut
2023-02-20  7:48   ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).