From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 10/12] video: Add ADV751[13] DT bindings documentation Date: Thu, 25 Sep 2014 12:57:13 +0300 Message-ID: <7167797.cQ2LzKYS7F@avalon> References: <1411589072-28609-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1411589072-28609-11-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Geert Uytterhoeven Cc: "devicetree@vger.kernel.org" , Laurent Pinchart , DRI Development , Linux-sh list List-Id: devicetree@vger.kernel.org Hi Geert, On Thursday 25 September 2014 09:06:46 Geert Uytterhoeven wrote: > Hi Laurent, > > On Wed, Sep 24, 2014 at 10:04 PM, Laurent Pinchart > > wrote: > > +- adi,input-style: The input components arrangement variant (1, 2 or 3). > > What's the meaning of the numerical values 1, 2, and 3? > > I found this code in "[PATCH 11/12] drm: Add adv7511 encoder driver": > > + input_style = config->input_style == 1 ? 2 > + : (config->input_style == 2 ? 1 : 3); > > which didn't really help much ;-) :-) The ADV751[13]W? datasheets document all the supported input formats. They're split in categories, each of them having multiple variants called styles. The styles are just numbered 1, 2 and 3 in the tables that describe the formats, and there's a register field used to select a style. For some reason style 1 maps to register value 2, style 2 to register value 1, and style 3 to register value 3. Go figure... -- Regards, Laurent Pinchart