devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Thomas Abraham <ta.omasab@gmail.com>,
	cpufreq@vger.kernel.org, devicetree@vger.kernel.org,
	l.majewski@samsung.com, kgene.kim@samsung.com,
	mturquette@linaro.org, heiko@sntech.de, viresh.kumar@linaro.org,
	t.figa@samsung.com, rjw@rjwysocki.net,
	linux-samsung-soc@vger.kernel.org, thomas.ab@samsung.com,
	shawn.guo@linaro.org
Subject: Re: [PATCH v4 0/8] cpufreq: use cpufreq-cpu0 driver for exynos based platforms
Date: Wed, 14 May 2014 14:51:22 +0200	[thread overview]
Message-ID: <7170433.Ah6fefFrHR@wuerfel> (raw)
In-Reply-To: <1400029876-5830-1-git-send-email-thomas.ab@samsung.com>

On Wednesday 14 May 2014 06:41:08 Thomas Abraham wrote:
> 
> The patch series removes the use of Exynos specific cpufreq driver and enables
> the use of cpufreq-cpu0 driver for Exynos4210, Exynos4x12 and Exynos5250 based
> platforms. This is being done for few reasons.
> 
> (a) The Exynos cpufreq driver reads/writes clock controller registers
>     bypassing the Exynos CCF driver which is sort of problematic.
> (b) Removes the need for having clock controller register definitions
>     in the cpufreq driver and also removes the need for statically
>     io-remapping clock controller address space (helps in moving towards
>     multiplatform kernel).
> 

Thanks a lot for your continued effort. Looks great overall, but I have one
comment about the general way the cpu0 cpufreq driver works, not specific
to the exynos implementation. See my reply to patch 4.

	Arnd

  parent reply	other threads:[~2014-05-14 12:51 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14  1:11 [PATCH v4 0/8] cpufreq: use cpufreq-cpu0 driver for exynos based platforms Thomas Abraham
2014-05-14  1:11 ` [PATCH v4 1/8] cpufreq: cpufreq-cpu0: allow use of optional boost mode frequencies Thomas Abraham
2014-05-14  3:46   ` Viresh Kumar
2014-05-14  6:17     ` Lukasz Majewski
2014-05-14  6:20       ` Viresh Kumar
2014-05-14 13:43         ` Thomas Abraham
2014-05-14 13:50           ` Viresh Kumar
2014-05-14 14:18             ` Thomas Abraham
2014-05-14 14:20               ` Viresh Kumar
2014-05-14  1:11 ` [PATCH v4 2/8] clk: samsung: change scope of samsung clock lock to global Thomas Abraham
2014-05-14  3:50   ` Viresh Kumar
2014-05-14 13:26     ` Thomas Abraham
2014-05-16 12:30   ` Tomasz Figa
2014-05-14  1:11 ` [PATCH v4 3/8] clk: samsung: add infrastructure to register cpu clocks Thomas Abraham
2014-05-15 18:18   ` Doug Anderson
2014-05-15 19:17     ` Heiko Stübner
2014-05-15 19:36       ` Doug Anderson
2014-05-15 20:12         ` Heiko Stübner
2014-05-15 20:26           ` Doug Anderson
2014-05-16  4:55             ` Thomas Abraham
2014-05-16 17:17   ` Tomasz Figa
2014-05-23 14:41     ` Thomas Abraham
2014-05-23 14:50       ` Tomasz Figa
2014-05-14  1:11 ` [PATCH v4 4/8] Documentation: devicetree: add cpu clock configuration data binding for Exynos4/5 Thomas Abraham
2014-05-16 23:24   ` Tomasz Figa
2014-05-17  0:00     ` Tomasz Figa
2014-05-26  6:05     ` Thomas Abraham
2014-05-26 11:02       ` Tomasz Figa
2014-05-14  1:11 ` [PATCH v4 5/8] clk: exynos: use cpu-clock provider type to represent arm clock Thomas Abraham
2014-05-14 21:37   ` Mike Turquette
2014-05-15  7:48     ` Thomas Abraham
2014-05-15  8:10       ` Lukasz Majewski
2014-05-15  9:59         ` Thomas Abraham
2014-05-16  5:14     ` Thomas Abraham
2014-05-16 23:57   ` Tomasz Figa
2014-05-14  1:11 ` [PATCH v4 6/8] ARM: dts: Exynos: add cpu nodes, opp and cpu clock configuration data Thomas Abraham
2014-05-16 23:16   ` Tomasz Figa
2014-05-14  1:11 ` [PATCH v4 7/8] ARM: Exynos: switch to using generic cpufreq-cpu0 driver Thomas Abraham
2014-05-14 12:50   ` Arnd Bergmann
2014-05-14 13:05     ` Viresh Kumar
2014-05-14 13:11       ` Heiko Stübner
2014-05-14 13:14         ` Viresh Kumar
2014-05-14 13:18           ` Arnd Bergmann
2014-05-14 13:45             ` Rob Herring
2014-05-14 14:33               ` Arnd Bergmann
2014-07-08  5:15                 ` Viresh Kumar
2014-05-14 14:03         ` Thomas Abraham
2014-05-14 14:09           ` Sudeep Holla
2014-05-14 14:09     ` Thomas Abraham
2014-05-17  0:04   ` Tomasz Figa
2014-05-14  1:11 ` [PATCH v4 8/8] cpufreq: exynos: remove all exynos specific cpufreq driver support Thomas Abraham
2014-05-14  3:57   ` Viresh Kumar
2014-05-14  7:20   ` Lukasz Majewski
2014-05-14 13:53     ` Thomas Abraham
2014-05-14 12:51 ` Arnd Bergmann [this message]
2014-05-14 13:07   ` [PATCH v4 0/8] cpufreq: use cpufreq-cpu0 driver for exynos based platforms Viresh Kumar
2014-05-14 13:16     ` Arnd Bergmann
2014-05-17  0:14 ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7170433.Ah6fefFrHR@wuerfel \
    --to=arnd@arndb.de \
    --cc=cpufreq@vger.kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=kgene.kim@samsung.com \
    --cc=l.majewski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=rjw@rjwysocki.net \
    --cc=shawn.guo@linaro.org \
    --cc=t.figa@samsung.com \
    --cc=ta.omasab@gmail.com \
    --cc=thomas.ab@samsung.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).