From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66F8F3D45E5; Tue, 28 Jul 2026 08:19:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785226752; cv=none; b=V7Ueh/Poh1AQACHTCJF9jxB+KyHQf55fbhPe4HluvERlEOeo5v4JWgLTNkEHrmCbtw2gjLO8IsD9lrdWUeR5XhyF2Jr49xBtuMazUYF7rS+Lm4NQPb+zp4IrLOBvfJZ1+2Ppjv+qL8pNqcg037V11d6gTTmGDwSedP02ARAz4GA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785226752; c=relaxed/simple; bh=15hB1757LiLTIRMyYV/RJuiDjzhaKOUGGk3engEhBkE=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=iN5luHyGuK8qw5jWxC6PtcHqJMZ0nq/pN7O4T6409aNptmeRqgrAFA7/cfTo/e0YfvIStuBn8Q9WdTHFQt6cau07Uan7FZwoNJk5STbf14JrFoL3hy2jign4Z2MsMBCkjko4bH4Kg/lBE8Dl3G/6H2AwMqshFkyyKq3ktFVtDUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QkKx6HLi; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QkKx6HLi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 159D01F000E9; Tue, 28 Jul 2026 08:19:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785226751; bh=GwZfz8cUW7ubQKNfUxZKDV8XaACxV5a2bt0UrXx5OHs=; h=Date:Subject:From:To:Cc:References:In-Reply-To; b=QkKx6HLixRM/1qUXvj2QULCngHqJB1EcvJTKvJDCWDtXF3+De+JZcQYpClXoyYsql UGRt1bWOVavRYnuLJUJK70TjhfvUIn3b/v3xFsBnN+rl+0zE8+Osc1Qo1QR6IbGC0D dC4mkfkWiNowQp+qftiQ7z+iV9lHjb7Vogmdf+W8Byz599T44am28hst4M8GVt+Bnq lQ4LrjqsoAssN1peSgX9rMvG/zZ0JQRW8WKirR4ZCEGGkiv27JV/MmeU1iVAaa7ZKQ P8ysZJJfWsYALIyj3haFX9bZfqLtQYmLehz9QMWIwpenABAtin2sotFXofWl61p4Ce xwgRO+it7UgEw== Message-ID: <7170fad9-8dba-4810-aa62-62cf372dead1@kernel.org> Date: Tue, 28 Jul 2026 10:19:01 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [hwmon-next PATCH v3 1/4] dt-bindings: hwmon: adi,adt7470 From: Krzysztof Kozlowski To: Luiz Angelo Daros de Luca Cc: Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Packham , Andrew Morton , "Darrick J. Wong" , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org References: <20260728-adt7470_thermalzone-v3-0-d4586478cdba@gmail.com> <20260728-adt7470_thermalzone-v3-1-d4586478cdba@gmail.com> <20260728-meteoric-quixotic-sunfish-0de2cb@quoll> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20260728-meteoric-quixotic-sunfish-0de2cb@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/07/2026 10:14, Krzysztof Kozlowski wrote: > On Tue, Jul 28, 2026 at 12:07:09AM -0300, Luiz Angelo Daros de Luca wrote: >> The Analog Devices ADT7470 is a multichannel temperature sensor and >> PWM fan controller. It supports monitoring up to 10 external >> temperature sensors and controlling up to 4 fans. >> >> Add the device tree binding documentation for it. This includes >> support for the thermal framework by defining the "#thermal-sensor-cells" >> property, and models the fan control lines as PWM channels by >> defining the "#pwm-cells" property. >> >> Signed-off-by: Luiz Angelo Daros de Luca >> --- >> .../devicetree/bindings/hwmon/adi,adt7470.yaml | 55 ++++++++++++++++++++++ >> 1 file changed, 55 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adt7470.yaml b/Documentation/devicetree/bindings/hwmon/adi,adt7470.yaml >> new file mode 100644 >> index 000000000000..bb2375a4a490 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/adi,adt7470.yaml >> @@ -0,0 +1,55 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/hwmon/adi,adt7470.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Analog Devices ADT7470 hwmon sensor >> + >> +maintainers: >> + - Luiz Angelo Daros de Luca >> + >> +description: >> + Multi-channel temperature monitor and PWM fan controller. >> + It supports monitoring up to 10 external temperature sensors and >> + controlling up to four fans. The fan control lines are modeled >> + as standard PWM channels. >> + >> +properties: >> + compatible: >> + const: adi,adt7470 >> + >> + reg: >> + maxItems: 1 >> + >> + "#pwm-cells": >> + const: 3 >> + description: >> + See Documentation/devicetree/bindings/pwm/pwm.yaml for the >> + generic PWM binding description. > > Drop description. > > You OTOH, miss ref to pwm schema. Referencing here in description should > raise you questions... And then use unevaluatedProperties. > You most likely miss ref to thermal-sensor.yaml as well, but that would change the ABI since hwmon would fail on missing cells, right? Best regards, Krzysztof