From: Arnd Bergmann <arnd@arndb.de>
To: Joshua Henderson <joshua.henderson@microchip.com>
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
Purna Chandra Mandal <purna.mandal@microchip.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 03/14] DEVICETREE: Add PIC32 clock binding documentation
Date: Sat, 21 Nov 2015 21:49:20 +0100 [thread overview]
Message-ID: <7182714.6Xmo6Noc6V@wuerfel> (raw)
In-Reply-To: <1448065205-15762-4-git-send-email-joshua.henderson@microchip.com>
On Friday 20 November 2015 17:17:15 Joshua Henderson wrote:
> +/* PIC32 specific clks */
> +pic32_clktree {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + reg = <0x1f801200 0x200>;
> + compatible = "microchip,pic32-clk";
> + interrupts = <12>;
> + ranges;
> +
> + /* secondary oscillator; external input on SOSCI pin */
> + SOSC:sosc_clk {
> + #clock-cells = <0>;
> + compatible = "microchip,pic32-sosc";
> + clock-frequency = <32768>;
> + reg = <0x1f801200 0x10 /* enable reg */
> + 0x1f801390 0x10>; /* status reg */
> + microchip,bit-mask = <0x02>; /* enable mask */
> + microchip,status-bit-mask = <0x10>; /* status-mask*/
> + };
>
If you want to use the reg property in this way for each cell,
at least use a 'ranges' that only translates the actual registers
like this
ranges = <0 0x1f801200 0x200>
sosc_clk {
...
reg = <0x000 0x10>, <0x190 0x10>;
...
};
Arnd
next prev parent reply other threads:[~2015-11-21 20:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 0:17 [PATCH 00/14] Initial Microchip PIC32MZDA Support Joshua Henderson
2015-11-21 0:17 ` [PATCH 01/14] DEVICETREE: Add bindings for PIC32 interrupt controller Joshua Henderson
2015-11-21 20:47 ` Arnd Bergmann
2015-11-25 18:22 ` Joshua Henderson
[not found] ` <1448065205-15762-2-git-send-email-joshua.henderson-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
2015-11-22 21:14 ` Rob Herring
2015-11-26 5:01 ` Joshua Henderson
2015-11-21 0:17 ` [PATCH 03/14] DEVICETREE: Add PIC32 clock binding documentation Joshua Henderson
2015-11-21 20:49 ` Arnd Bergmann [this message]
2015-11-26 4:05 ` Joshua Henderson
[not found] ` <1448065205-15762-4-git-send-email-joshua.henderson-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
2015-11-22 21:31 ` Rob Herring
2015-11-26 5:36 ` Joshua Henderson
2015-11-30 21:43 ` Rob Herring
2015-12-03 17:37 ` Joshua Henderson
2015-11-21 0:17 ` [PATCH 05/14] DEVICETREE: Add bindings for PIC32/MZDA platforms Joshua Henderson
2015-11-22 21:35 ` Rob Herring
2015-11-21 0:17 ` [PATCH 07/14] DEVICETREE: Add bindings for PIC32 pin control and GPIO Joshua Henderson
2015-11-22 21:47 ` Rob Herring
2015-12-04 13:02 ` Andrei.Pistirica
2015-12-08 22:13 ` Joshua Henderson
2015-11-21 0:17 ` [PATCH 09/14] DEVICETREE: Add bindings for PIC32 usart driver Joshua Henderson
2015-11-21 15:20 ` Sergei Shtylyov
2015-11-22 21:56 ` Rob Herring
2015-12-11 16:16 ` Joshua Henderson
2015-11-21 0:17 ` [PATCH 12/14] DEVICETREE: Add bindings for PIC32 SDHC host controller Joshua Henderson
2015-11-21 15:19 ` Sergei Shtylyov
2015-11-26 4:40 ` Joshua Henderson
2015-11-22 21:57 ` Rob Herring
2015-11-26 5:16 ` Joshua Henderson
2015-11-21 0:17 ` [PATCH 13/14] MIPS: dts: Add initial DTS for the PIC32MZDA Starter Kit Joshua Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7182714.6Xmo6Noc6V@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joshua.henderson@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=purna.mandal@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).