Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn

[Krzysztof Kozlowski <krzk@kernel.org>]

On 08/06/2026 13:51, Biju Das wrote:
> Hi Krzysztof Kozlowski,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 08 June 2026 12:47
>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn
>>
>> On 08/06/2026 13:22, Biju Das wrote:
>>> Hi Krzysztof Kozlowski,
>>>
>>>> -----Original Message-----
>>>> From: Krzysztof Kozlowski <krzk@kernel.org>
>>>> Sent: 08 June 2026 12:11
>>>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required
>>>> for renesas,r9a08g046-lvds-cmn
>>>>
>>>> On 08/06/2026 12:26, Biju Das wrote:
>>>>> Hi Krzysztof Kozlowski,
>>>>>
>>>>> Thanks for the feedback.
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Krzysztof Kozlowski <krzk@kernel.org>
>>>>>> Sent: 08 June 2026 11:22
>>>>>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required
>>>>>> for renesas,r9a08g046-lvds-cmn
>>>>>>
>>>>>> On 08/06/2026 12:20, Krzysztof Kozlowski wrote:
>>>>>>> On Tue, Jun 02, 2026 at 02:13:29PM +0100, Biju wrote:
>>>>>>>> From: Biju Das <biju.das.jz@bp.renesas.com>
>>>>>>>>
>>>>>>>> Add a conditional schema rule to the syscon bindings that
>>>>>>>> requires the ranges property when the compatible string contains
>>>>>>>> renesas,r9a08g046-lvds-cmn. This ensures the LVDS common control
>>>>>>>> block on the RZ/G3L SoC correctly declares its address
>>>>>>>> translation, as the device has child nodes that need a valid
>>>>>>>> ranges mapping to be described in the device tree.
>>>>>>>>
>>>>>>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>>>>>>>> ---
>>>>>>>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 14
>>>>>>>> ++++++++++++++
>>>>>>>>  1 file changed, 14 insertions(+)
>>>>>>>>
>>>>>>>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>>>>>> b/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>>>>>> index 9c81010d5a74..cbf83a06ae25 100644
>>>>>>>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>>>>>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>>>>>> @@ -269,6 +269,8 @@ properties:
>>>>>>>>    resets:
>>>>>>>>      maxItems: 1
>>>>>>>>
>>>>>>>> +  ranges: true
>>>>>>>
>>>>>>> There are no children allowed, so ranges property is wrong.
>>>>>>>
>>>>>>> You are changing binding which DOES NOT allow simple-mfd or any
>>>>>>> other children. Ranges is not a problem here.
>>>>>>
>>>>>>
>>>>>> And if you tested it on your DTS, you would see this does not work...
>>>>>
>>>>> I don't see any warnings or error. I have done this change based on
>>>>> Rob's comment based on sashiko review [1].
>>>>>
>>>>> If you agree, I can drop this patch.
>>>>>
>>>>> [1]
>>>>> https://lore.kernel.org/all/20260601022619.GA3961324-robh@kernel.org
>>>>> /
>>>>
>>>> Look:
>>>> https://lore.kernel.org/all/20260524194457.479681-2-biju.das.jz@bp.re
>>>> nesas.com/
>>>> What compatibles are here?
>>>>
>>>> Now open the binding - what compatibles are allowed for renesas,r9a08g046-lvds-cmn ?
>>>
>>> OK, I am missing the fallbacks "simple-mfd", "syscon"; in the
>>> compatibles allowed for renesas,r9a08g046-lvds-cmn.
>>>
>>> OK, I will add those.
>>
>> No, maybe, dunno... How anything here could have been tested? dtbs_check clearly points errors on your
>> DTS.
> 
> I ran the below commands and none of then triggered the error/warning you are suspecting.
> Am I missing anything here?
> 
> make ARCH=arm64 DT_CHECKER_FLAGS=-m DT_SCHEMA_FILES=${1} CROSS_COMPILE=~/${TOOL_CHAIN}/bin/aarch64-none-linux-gnu- dt_binding_check -j32
> make ARCH=arm64 -s dtbs_check -j32
> make ARCH=arm64 DT_SCHEMA_FILES=${1} CROSS_COMPILE=~/${TOOL_CHAIN}/bin/aarch64-none-linux-gnu- -s dtbs_check -j32
> make ARCH=arm64 CROSS_COMPILE=~/${TOOL_CHAIN}/bin/aarch64-none-linux-gnu- W=1 dtbs -j32 2>&1 | tee -a arm64-dtbs.log

No, you must validate all schemas, not one file. And without DTS
obviously this will not point any error on dtbs_check.

I am reverting your commit.

Best regards,
Krzysztof