From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vitaly Rodionov <vitalyr@opensource.cirrus.com>,
Mark Brown <broonie@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 06/11] ASoC: dt-bindings: sound: cirrus: cs530x: Add cs530x variants
Date: Sun, 19 Oct 2025 12:32:20 +0200 [thread overview]
Message-ID: <71c6d7e4-0565-4444-a28e-b3432e209373@kernel.org> (raw)
In-Reply-To: <20251017161543.214235-7-vitalyr@opensource.cirrus.com>
On 17/10/2025 18:15, Vitaly Rodionov wrote:
> This patch adds additional cs530x family variants.
>
> cirrus,cs4282 - high-performance, 32-bit resolution, stereo CODEC
> cirrus,cs4302 - high performance stereo DAC, 2 channels
> cirrus,cs4304 - high performance stereo DAC, 4 channels
> cirrus,cs4308 - high performance stereo DAC, 8 channels
>
> Signed-off-by: Vitaly Rodionov <vitalyr@opensource.cirrus.com>
> ---
> Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> index 9582eb8eb418..90a5cea0632d 100644
> --- a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> @@ -22,6 +22,10 @@ properties:
> - cirrus,cs5302
> - cirrus,cs5304
> - cirrus,cs5308
> + - cirrus,cs4282
> + - cirrus,cs4302
> + - cirrus,cs4304
> + - cirrus,cs4308
I asked about fixing this at v1. You ignored it. Then I reminded this at
v3. You sent v4 still ignoring my comment.
I don't know what to do more.
NAK
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-19 10:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 16:15 [PATCH v4 00/11] Add support for Cirrus Logic CS530x DAC and CODEC variants Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 01/11] ASoC: cs530x: Correct log message with expected variable Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 02/11] ASoC: cs530x: Update the copyright headers Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 03/11] ASoC: cs530x: Sort #include directives and tidy up whitespaces Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 04/11] ASoC: cs530x: Remove unused struct members and constants Vitaly Rodionov
2025-10-17 16:28 ` Mark Brown
2025-10-17 16:15 ` [PATCH v4 05/11] ASoC: cs530x: Correct constant naming Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 06/11] ASoC: dt-bindings: sound: cirrus: cs530x: Add cs530x variants Vitaly Rodionov
2025-10-17 16:31 ` Mark Brown
2025-10-17 16:46 ` Vitaly Rodionov
2025-10-19 10:32 ` Krzysztof Kozlowski [this message]
2025-10-19 14:23 ` Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 07/11] ASoC: cs530x: Add CODEC and DAC support Vitaly Rodionov
2025-10-17 16:41 ` Mark Brown
2025-10-17 16:15 ` [PATCH v4 08/11] ASoC: cs530x: Check the DEVID matches the devtype Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 09/11] ASoC: cs530x: Correct MCLK reference frequency values Vitaly Rodionov
2025-10-17 16:44 ` Mark Brown
2025-10-17 16:57 ` Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 10/11] ASoC: cs530x: Rename i2c related structures Vitaly Rodionov
2025-10-17 16:15 ` [PATCH v4 11/11] ASoC: cs530x: Add SPI bus support for cs530x parts Vitaly Rodionov
2025-10-17 16:46 ` Mark Brown
2025-10-21 12:11 ` (subset) [PATCH v4 00/11] Add support for Cirrus Logic CS530x DAC and CODEC variants Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71c6d7e4-0565-4444-a28e-b3432e209373@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
--cc=vitalyr@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox