Re: [PATCH v4 2/9] media: qcom: venus: add common clocks used by both vdec and venc

Krzysztof Kozlowski
2026-05-06T07:37:03Z

On Wed, May 06, 2026 at 12:44:39AM +0300, Erikas Bitovtas wrote:
> Add clocks which are enabled during both decode and encode. This shall
> be used in newer bindings for Venus, where subnodes for video decoder
> and video encoder are not included and clocks are not differentiated
> between decode and encode.
>
> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> ---
> drivers/media/platform/qcom/venus/core.h | 3 +++
> 1 file changed, 3 insertions(+)

I still do not understand why this patchset has such mixed arrangement.
First media patches, then SoC, then clock, then again media.

Please follow submitting patches in DT - DTS CANNOT be stuffed in the
middle.

>
> diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platform/qcom/venus/core.h
> index 7506f5d0f609..c1d772c7ae9b 100644
> --- a/drivers/media/platform/qcom/venus/core.h
> +++ b/drivers/media/platform/qcom/venus/core.h
> @@ -77,6 +77,7 @@ struct venus_resources {
> const struct hfi_ubwc_config *ubwc_conf;
> const char * const clks[VIDC_CLKS_NUM_MAX];
> unsigned int clks_num;
> + const char * const vcodec_clks[VIDC_VCODEC_CLKS_NUM_MAX];

This is dead code. Drop or organize your patches correctly, so there
will be user of this. Each patch is one logical change. Adding dead code
is not a logical change, because it is unused, thus completely
redundant.

Best regards,
Krzysztof