From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Maarten Zanders <maarten.zanders@mind.be>,
Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] leds: lp55xx: configure internal charge pump
Date: Thu, 2 Feb 2023 10:34:21 +0100 [thread overview]
Message-ID: <71c9963c-98e3-d90b-116a-68a295feb24a@linaro.org> (raw)
In-Reply-To: <20230202092325.21241-1-maarten.zanders@mind.be>
On 02/02/2023 10:23, Maarten Zanders wrote:
> A new option in the devicetree "ti,charge-pump-mode" allows the user to
> configure the charge pump in a certain mode. The previous implementation
> was "auto" mode, which remains the default.
>
> v1 of the patch implemented a bool to disable the charge pump and had some
> issues in the yaml binding.
>
> v2 implemented all options of the charge pump as a string which was too
> complex to parse & check.
>
> v3 (this version) replaces the string by constants.
Please resend without ignoring the feedback.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-02 9:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 9:23 [PATCH v3 0/2] leds: lp55xx: configure internal charge pump Maarten Zanders
2023-02-02 9:23 ` [PATCH v3 1/2] dt-bindings: leds-lp55xx: add ti,charge-pump-mode Maarten Zanders
2023-02-02 9:33 ` Krzysztof Kozlowski
2023-02-02 9:23 ` [PATCH v3 2/2] leds: lp55xx: configure internal charge pump Maarten Zanders
2023-02-02 9:34 ` Krzysztof Kozlowski [this message]
2023-02-02 11:00 ` [PATCH v3 0/2] " Maarten Zanders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71c9963c-98e3-d90b-116a-68a295feb24a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=maarten.zanders@mind.be \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).