From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D05DC6FA86 for ; Thu, 8 Sep 2022 14:43:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231590AbiIHOnT (ORCPT ); Thu, 8 Sep 2022 10:43:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231741AbiIHOnR (ORCPT ); Thu, 8 Sep 2022 10:43:17 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A444B7960F for ; Thu, 8 Sep 2022 07:43:15 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id m15so8417834lfl.9 for ; Thu, 08 Sep 2022 07:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=n8VGGC+7+I4IjFN0ib/PUjyurgUsEjooklHf6RmDYUg=; b=ZxdGhDBFjbOpQmDm+bvokfEUhGG1h4jISBv5G5/iyMzHUYo7MnhY5DCOp8n4Is7E0Z TQTTn9foxYpacFYzuB0/d1SJabnhH/mgJR82/CeiVTjvwgeQHI53w1FF2AL2D7UwIFGY W2LUkr6K/RkMpBo8gNMhXcp4LiQSyz1W11dvTKUjs3+Ux4uh2UZTfG2vk7bkaCnY+eRm jTT/Chbtx29UvPTz+OGPLt1w/xNbNEERAhEFW+5WAGTncArweLWKH/9D5pyl2efWhl3i pIAhsH2AWnyEwLTYmujSexcgV4wPY/rtEZpEDVNeYcsz1uwAGG2Cc5lC2ROg/Z9A00TD vFBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=n8VGGC+7+I4IjFN0ib/PUjyurgUsEjooklHf6RmDYUg=; b=m8ivv/v+YBcAk1mYd3Lm/UuGsgGzaziAklYVDJksnOpcjw7+NRt7A/k9UK/WPfvm+B acNOaehsD9E/CETF4au9HC2wv3N6PwMkJMI3INc8+Ai/ZbicCYe3yFx4o4ZZ+QmfDEtP +uquZFpaaSgsxC+JEum0NDzz2yEtqpV0grIt3X10H+YPaxza2fV+8zTsEq8JVr8h31dA X42YbFs/TakfOFACRAvy38FEOrH+wKYk7kwsCAXMtM657rHuUXZtriYevkV5zpbR3T8y B3d/GrH0cB3TIH20yYH0tLl+uSjjyWydo89k6+DcbMaCNe6EiC27UnNx1NQ15fGVTNxF GR4w== X-Gm-Message-State: ACgBeo1SRoqNfBqcxyvZGS5L/oD1+IAOqh8QZb6eETe89kVoNUS8jTQH 4+bP0d62JGuIzViRjiU2XN6c2Q== X-Google-Smtp-Source: AA6agR4vo2geJ+bD2HdOnszq/5/BOl1SbzOVNQ+QLutzfKR1QkYQv+a7YFX6i+H7RE1zgYN8hG1jsA== X-Received: by 2002:a05:6512:152a:b0:496:80f3:7fe0 with SMTP id bq42-20020a056512152a00b0049680f37fe0mr2823929lfb.579.1662648195222; Thu, 08 Sep 2022 07:43:15 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id a6-20020a05651c010600b002688cceee44sm3221569ljb.132.2022.09.08.07.43.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Sep 2022 07:43:14 -0700 (PDT) Message-ID: <71d970bc-fe6f-91e7-80c1-711af1af5530@linaro.org> Date: Thu, 8 Sep 2022 16:43:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 4/4] dt-bindings: net: snps,dwmac: Update interrupt-names Content-Language: en-US To: Bhupesh Sharma , devicetree@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, agross@kernel.org, bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, netdev@vger.kernel.org, Bjorn Andersson , Rob Herring , Vinod Koul , David Miller References: <20220907204924.2040384-1-bhupesh.sharma@linaro.org> <20220907204924.2040384-5-bhupesh.sharma@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220907204924.2040384-5-bhupesh.sharma@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/09/2022 22:49, Bhupesh Sharma wrote: > As commit fc191af1bb0d ("net: stmmac: platform: Fix misleading > interrupt error msg") noted, not every stmmac based platform > makes use of the 'eth_wake_irq' or 'eth_lpi' interrupts. > > So, update the 'interrupt-names' inside 'snps,dwmac' YAML > bindings to reflect the same. > > Cc: Bjorn Andersson > Cc: Rob Herring > Cc: Vinod Koul > Cc: David Miller > Signed-off-by: Bhupesh Sharma > --- > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index f89ca308d55f..4d7fe4ee3d87 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -105,10 +105,12 @@ properties: > > interrupt-names: > minItems: 1 > - items: > - - const: macirq > - - const: eth_wake_irq > - - const: eth_lpi > + maxItems: 3 > + contains: > + enum: > + - macirq > + - eth_wake_irq > + - eth_lpi > This gives quite a flexibility, e.g. missing macirq. Instead should be probably a list with enums: items: - const: macirq - enum: [eth_wake_irq, eth_lpi] - enum: [eth_wake_irq, eth_lpi] Best regards, Krzysztof