* [PATCH 1/2] arm64: dts: altera: align LED node names with dtschema
@ 2022-11-25 14:42 Krzysztof Kozlowski
2022-11-25 14:42 ` [PATCH 2/2] ARM: dts: socfpga: " Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-25 14:42 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
The node names should be generic and DT schema expects certain pattern:
altera/socfpga_stratix10_socdk.dtb: leds: 'hps0', 'hps1', 'hps2' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 6 +++---
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
index 48424e459f12..dd2b41350412 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
@@ -22,17 +22,17 @@ chosen {
leds {
compatible = "gpio-leds";
- hps0 {
+ led-hps0 {
label = "hps_led0";
gpios = <&portb 20 GPIO_ACTIVE_HIGH>;
};
- hps1 {
+ led-hps1 {
label = "hps_led1";
gpios = <&portb 19 GPIO_ACTIVE_HIGH>;
};
- hps2 {
+ led-hps2 {
label = "hps_led2";
gpios = <&portb 21 GPIO_ACTIVE_HIGH>;
};
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts
index 847a7c01f5af..ede99dcc0558 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts
@@ -22,17 +22,17 @@ chosen {
leds {
compatible = "gpio-leds";
- hps0 {
+ led-hps0 {
label = "hps_led0";
gpios = <&portb 20 GPIO_ACTIVE_HIGH>;
};
- hps1 {
+ led-hps1 {
label = "hps_led1";
gpios = <&portb 19 GPIO_ACTIVE_HIGH>;
};
- hps2 {
+ led-hps2 {
label = "hps_led2";
gpios = <&portb 21 GPIO_ACTIVE_HIGH>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 2/2] ARM: dts: socfpga: align LED node names with dtschema
2022-11-25 14:42 [PATCH 1/2] arm64: dts: altera: align LED node names with dtschema Krzysztof Kozlowski
@ 2022-11-25 14:42 ` Krzysztof Kozlowski
2022-11-30 15:01 ` Dinh Nguyen
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-25 14:42 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
The node names should be generic and DT schema expects certain pattern:
socfpga_arria5_socdk.dtb: leds: 'hps0', 'hps1', 'hps2', 'hps3' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/socfpga_arria5_socdk.dts | 8 ++++----
arch/arm/boot/dts/socfpga_cyclone5_de0_nano_soc.dts | 2 +-
arch/arm/boot/dts/socfpga_cyclone5_socdk.dts | 8 ++++----
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/socfpga_arria5_socdk.dts b/arch/arm/boot/dts/socfpga_arria5_socdk.dts
index 7f5458d8fccc..c48385702a85 100644
--- a/arch/arm/boot/dts/socfpga_arria5_socdk.dts
+++ b/arch/arm/boot/dts/socfpga_arria5_socdk.dts
@@ -29,22 +29,22 @@ aliases {
leds {
compatible = "gpio-leds";
- hps0 {
+ led-hps0 {
label = "hps_led0";
gpios = <&porta 0 1>;
};
- hps1 {
+ led-hps1 {
label = "hps_led1";
gpios = <&portb 11 1>;
};
- hps2 {
+ led-hps2 {
label = "hps_led2";
gpios = <&porta 17 1>;
};
- hps3 {
+ led-hps3 {
label = "hps_led3";
gpios = <&porta 18 1>;
};
diff --git a/arch/arm/boot/dts/socfpga_cyclone5_de0_nano_soc.dts b/arch/arm/boot/dts/socfpga_cyclone5_de0_nano_soc.dts
index c8f051fb2bf6..bedf577cb056 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_de0_nano_soc.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_de0_nano_soc.dts
@@ -33,7 +33,7 @@ regulator_3_3v: regulator {
leds {
compatible = "gpio-leds";
- hps0 {
+ led-hps0 {
label = "hps_led0";
gpios = <&portb 24 0>;
linux,default-trigger = "heartbeat";
diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
index b2241205c7a9..c7f5fa0ba0f2 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
@@ -29,22 +29,22 @@ aliases {
leds {
compatible = "gpio-leds";
- hps0 {
+ led-hps0 {
label = "hps_led0";
gpios = <&portb 15 1>;
};
- hps1 {
+ led-hps1 {
label = "hps_led1";
gpios = <&portb 14 1>;
};
- hps2 {
+ led-hps2 {
label = "hps_led2";
gpios = <&portb 13 1>;
};
- hps3 {
+ led-hps3 {
label = "hps_led3";
gpios = <&portb 12 1>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 2/2] ARM: dts: socfpga: align LED node names with dtschema
2022-11-25 14:42 ` [PATCH 2/2] ARM: dts: socfpga: " Krzysztof Kozlowski
@ 2022-11-30 15:01 ` Dinh Nguyen
0 siblings, 0 replies; 3+ messages in thread
From: Dinh Nguyen @ 2022-11-30 15:01 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel
On 11/25/22 08:42, Krzysztof Kozlowski wrote:
> The node names should be generic and DT schema expects certain pattern:
>
> socfpga_arria5_socdk.dtb: leds: 'hps0', 'hps1', 'hps2', 'hps3' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm/boot/dts/socfpga_arria5_socdk.dts | 8 ++++----
> arch/arm/boot/dts/socfpga_cyclone5_de0_nano_soc.dts | 2 +-
> arch/arm/boot/dts/socfpga_cyclone5_socdk.dts | 8 ++++----
> 3 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/socfpga_arria5_socdk.dts b/arch/arm/boot/dts/socfpga_arria5_socdk.dts
> index 7f5458d8fccc..c48385702a85 100644
> --- a/arch/arm/boot/dts/socfpga_arria5_socdk.dts
> +++ b/arch/arm/boot/dts/socfpga_arria5_socdk.dts
> @@ -29,22 +29,22 @@ aliases {
>
> leds {
> compatible = "gpio-leds";
> - hps0 {
> + led-hps0 {
> label = "hps_led0";
> gpios = <&porta 0 1>;
> };
>
> - hps1 {
> + led-hps1 {
> label = "hps_led1";
> gpios = <&portb 11 1>;
> };
>
> - hps2 {
> + led-hps2 {
> label = "hps_led2";
> gpios = <&porta 17 1>;
> };
>
> - hps3 {
> + led-hps3 {
> label = "hps_led3";
> gpios = <&porta 18 1>;
> };
> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_de0_nano_soc.dts b/arch/arm/boot/dts/socfpga_cyclone5_de0_nano_soc.dts
> index c8f051fb2bf6..bedf577cb056 100644
> --- a/arch/arm/boot/dts/socfpga_cyclone5_de0_nano_soc.dts
> +++ b/arch/arm/boot/dts/socfpga_cyclone5_de0_nano_soc.dts
> @@ -33,7 +33,7 @@ regulator_3_3v: regulator {
>
> leds {
> compatible = "gpio-leds";
> - hps0 {
> + led-hps0 {
> label = "hps_led0";
> gpios = <&portb 24 0>;
> linux,default-trigger = "heartbeat";
> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
> index b2241205c7a9..c7f5fa0ba0f2 100644
> --- a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
> +++ b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
> @@ -29,22 +29,22 @@ aliases {
>
> leds {
> compatible = "gpio-leds";
> - hps0 {
> + led-hps0 {
> label = "hps_led0";
> gpios = <&portb 15 1>;
> };
>
> - hps1 {
> + led-hps1 {
> label = "hps_led1";
> gpios = <&portb 14 1>;
> };
>
> - hps2 {
> + led-hps2 {
> label = "hps_led2";
> gpios = <&portb 13 1>;
> };
>
> - hps3 {
> + led-hps3 {
> label = "hps_led3";
> gpios = <&portb 12 1>;
> };
Both patches applied!
Thanks,
Dinh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-30 15:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-25 14:42 [PATCH 1/2] arm64: dts: altera: align LED node names with dtschema Krzysztof Kozlowski
2022-11-25 14:42 ` [PATCH 2/2] ARM: dts: socfpga: " Krzysztof Kozlowski
2022-11-30 15:01 ` Dinh Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).