From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A312AC433F5 for ; Wed, 5 Oct 2022 07:11:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229484AbiJEHLR (ORCPT ); Wed, 5 Oct 2022 03:11:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbiJEHLP (ORCPT ); Wed, 5 Oct 2022 03:11:15 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D008A6DACF for ; Wed, 5 Oct 2022 00:11:14 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id bk15so24520595wrb.13 for ; Wed, 05 Oct 2022 00:11:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date; bh=B4NuR15p1M5h+Qpf+trsp5mYdzxvdiwFoP+0+HDomaA=; b=TuK5WGh0hEIyfywa/E8MohJHIfkBV4b2cRp99lOsAUg/E/4ktietnlg4HZGuIHCBlK yVwXX9K7be9jl4x/XN65u6YZ2QT5yoEVFV/Z0l66h8Pcnh5bCVujYYwEH+RRa/3wlxSX F6F1REJPglaOz3SyvhsJ/7PwDIGXBtkIO0D9/Lgv091Bu2h4lBO91wwY7eNu4Nzpg2W9 lV19fbIMkKJADRZVksT/KtnYzkiw09kquLpZ0kyp8VdgIWV+mFVbyMT5fZBlJnN4ZqlA 9buxUhkk0mL+M0BvnNWs3NzZkAnUFi+wW24E5A2DAPk44yeOy/z3CO2VP7wXq7NAiZVO W3Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=B4NuR15p1M5h+Qpf+trsp5mYdzxvdiwFoP+0+HDomaA=; b=xughehu89tTy3k9AxxzWZucItzCFeI8inc+uMXLFHmHfEgCvkoBMezOJL4sTDAQXqu BKGeNF1fbpY9wZMnovg/w7uCxh9wIDA0j6ThNxx7nHeXY5l5UfE0iSbjcKVZrT6nWNqa xikquSRtPQW4aU60Ot9c68aNz5ROFFw3WbvS19SYLFo8OkyprfsR5OWl9vRttvHbJB6Q LVv/Epqctcyn584jJifof5slcD4KM4BtjQaAIWNZRzn5y7xrtzWdMwUeKwwvTcYvg5Rv F8uGq5eGhooiSl28RhF5ZYNoD5fjJPPaJ0jOhpimhrwGdroPbLWmo8BSRohpaV91YTcg U3GQ== X-Gm-Message-State: ACrzQf2hh8YW/QDjjUl8CVm1hAVs5/iBce9co+ma2b6IpDcGXyOSVDo5 VyRDciGbLsj4gku9ooq5dY3i1yZ7Y/UFjzI4 X-Google-Smtp-Source: AMsMyM5Dd3WxdNnd9W4ljS+WL4sP+ML6m11PngmoIu9sDz9xnz0n/YxZIW53GLiY5XtM0gP+ujnwKg== X-Received: by 2002:a5d:4581:0:b0:228:a8e5:253c with SMTP id p1-20020a5d4581000000b00228a8e5253cmr17416176wrq.506.1664953873383; Wed, 05 Oct 2022 00:11:13 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:94af:b87a:5119:ff73? ([2a01:e0a:982:cbb0:94af:b87a:5119:ff73]) by smtp.gmail.com with ESMTPSA id d3-20020a5d6dc3000000b0022e3cba367fsm7752494wrz.100.2022.10.05.00.11.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Oct 2022 00:11:12 -0700 (PDT) Message-ID: <720cc44b-a6fd-5424-1db6-fda1290c23e7@linaro.org> Date: Wed, 5 Oct 2022 09:11:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth Content-Language: en-US To: allen.chen@ite.com.tw Cc: devicetree@vger.kernel.org, Kenneth.Hung@ite.com.tw, jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org, Jau-Chih.Tseng@ite.com.tw, airlied@linux.ie, dri-devel@lists.freedesktop.org, narmstrong@baylibre.com, linux-kernel@vger.kernel.org, robert.foss@linaro.org, treapking@chromium.org, Hermes.Wu@ite.com.tw, robh+dt@kernel.org, Laurent.pinchart@ideasonboard.com, andrzej.hajda@intel.com, jonas@kwiboo.se References: <20220929014456.30077-1-allen.chen@ite.com.tw> <20220929014456.30077-2-allen.chen@ite.com.tw> <087811c1bc224a468f117ca4f2fff3cd@ite.com.tw> Organization: Linaro Developer Services In-Reply-To: <087811c1bc224a468f117ca4f2fff3cd@ite.com.tw> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/10/2022 08:19, allen.chen@ite.com.tw wrote: > Hi > > data-lanes is output configuration. Maybe it is not suitable to put data-lanes in input endpoint. > extcon doesn't have output endpoint, so I don't know where to put is better. Ok it wasn't clear enough Then rename the property to something more specific like: ite,dp-output-data-lane-count Use the same naming scheme for the other property: ite,dp-output-max-pixel-clock-khz Neil > > -----Original Message----- > From: Neil Armstrong > Sent: Thursday, September 29, 2022 4:40 PM > To: Allen Chen (陳柏宇) > Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS ; Kenneth Hung (洪家倫) ; Jernej Skrabec ; Krzysztof Kozlowski ; Jau-Chih Tseng (曾昭智) ; David Airlie ; open list:DRM DRIVERS ; Neil Armstrong ; open list ; Robert Foss ; Pin-yen Lin ; Hermes Wu (吳佳宏) ; Rob Herring ; Laurent Pinchart ; Andrzej Hajda ; Jonas Karlman > Subject: Re: [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth > > Hi, > > On 29/09/2022 03:44, allen wrote: >> From: allen chen >> >> Add properties to restrict dp output data-lanes and clock. >> >> Signed-off-by: Pin-Yen Lin >> Signed-off-by: Allen Chen >> --- >> .../devicetree/bindings/display/bridge/ite,it6505.yaml | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml >> b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml >> index 833d11b2303a..62b9f2192202 100644 >> --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml >> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml >> @@ -52,6 +52,14 @@ properties: >> maxItems: 1 >> description: extcon specifier for the Power Delivery >> >> + data-lanes: >> + maxItems: 1 >> + description: restrict the dp output data-lanes with value of 1-4 > > Can't you use the data-lanes property in the first port endpoint ? > > Look at Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > >> + >> + max-pixel-clock-khz: >> + maxItems: 1 >> + description: restrict max pixel clock > > New vendor specific properties should have the ite, prefix. > >> + >> port: >> $ref: /schemas/graph.yaml#/properties/port >> description: A port node pointing to DPI host port node @@ -84,6 >> +92,8 @@ examples: >> pwr18-supply = <&it6505_pp18_reg>; >> reset-gpios = <&pio 179 1>; >> extcon = <&usbc_extcon>; >> + data-lanes = <2>; >> + max-pixel-clock-khz = <150000>; >> >> port { >> it6505_in: endpoint { > > Thanks, > Neil