From: Arnd Bergmann <arnd@arndb.de>
To: Loc Ho <lho@apm.com>
Cc: chris@printf.net, ulf.hansson@linaro.org,
michal.simek@xilinx.com, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
jcm@redhat.com, patches@apm.com
Subject: Re: [PATCH 1/3] Documentation: Update Arasan SDHC documentation for the APM X-Gene SoC SDHC DTS binding
Date: Mon, 19 May 2014 11:09:38 +0200 [thread overview]
Message-ID: <7213964.4Qu0G1nWOL@wuerfel> (raw)
In-Reply-To: <1400398918-1502-2-git-send-email-lho@apm.com>
On Sunday 18 May 2014 01:41:56 Loc Ho wrote:
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> @@ -8,14 +8,17 @@ Device Tree Bindings for the Arasan SDHCI Controller
> [3] Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
>
> Required Properties:
> - - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a'
> + - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or
> + 'xgene,arasan,sdhci-8.9a'
> - reg: From mmc bindings: Register location and length.
> - - clocks: From clock bindings: Handles to clock inputs.
> - - clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb"
>
The driver as you patch is in this version actually requires a second set
of registers. As I commented there, it's probably not the best way to do
things, but you also forgot to update the binding here.
Always make sure that the binding document actually documents what you
implement!
Arnd
next prev parent reply other threads:[~2014-05-19 9:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-18 7:41 [PATCH 0/3] mmc: Add APM X-Gene SoC SDHC controller support to Arasan SDHCI driver Loc Ho
[not found] ` <1400398918-1502-1-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2014-05-18 7:41 ` [PATCH 1/3] Documentation: Update Arasan SDHC documentation for the APM X-Gene SoC SDHC DTS binding Loc Ho
[not found] ` <1400398918-1502-2-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2014-05-18 7:41 ` [PATCH 2/3] mmc: Add APM X-Gene SoC SDHC controller support to Arasan SDHCI driver Loc Ho
[not found] ` <1400398918-1502-3-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2014-05-18 7:41 ` [PATCH 3/3] arm64: Add APM X-Gene SoC SDHC controller DTS entry Loc Ho
2014-05-19 9:07 ` [PATCH 2/3] mmc: Add APM X-Gene SoC SDHC controller support to Arasan SDHCI driver Arnd Bergmann
2014-05-29 18:45 ` Loc Ho
2014-05-19 9:09 ` Arnd Bergmann [this message]
2014-05-19 12:32 ` [PATCH 1/3] Documentation: Update Arasan SDHC documentation for the APM X-Gene SoC SDHC DTS binding Mark Rutland
2014-05-29 18:54 ` Loc Ho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7213964.4Qu0G1nWOL@wuerfel \
--to=arnd@arndb.de \
--cc=chris@printf.net \
--cc=devicetree@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=lho@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=patches@apm.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).