From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0650E155A57 for ; Wed, 15 May 2024 21:16:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715807818; cv=none; b=cIm5ibcpB/hd094uRa3eKg49C2VFKgzENeOIOqk/T5YGTJbSSdnh9GhayNbDRykK6clCV13q5EHjMysxIWoYKrIlSURiJM39pqLQ2mxh1P0kGbVQ5edgAbcyN1B/ZD2F3d/4qi2ponCGkw8XSBkDPJthwf2xu5YAug8eBiMKnMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715807818; c=relaxed/simple; bh=6PDXEOf/kBufPSsrOCtvBapcjEUqnaQjXJDs/jKsvSk=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=iYPZEqKlag24xxHQ/RYvciQZZBadYkVlip3k45v+xJZx4DMnkjdk0p1zFqQNdT2f3hug2ZfPAsbeUQUrpqfTkbTbV4sb3Usd2YGH7n/zRAlUqhMlWk9pcQXPYgOlz9dtnl8PVRKDbRUALCh/VEn4ubfcM5m3u/h97poBwNRzVkw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Anym1BH4; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Anym1BH4" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-34db9a38755so6902049f8f.1 for ; Wed, 15 May 2024 14:16:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715807815; x=1716412615; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=uO72t1z4PhC45RlSB4zxjIXXfxmOyzDDnn9KfpOoEe4=; b=Anym1BH4e7XlSZKIxxfAUsBT1knjDmOFjyZ2/wDHK7oSAHIK6EWujl3TOyRINpgtM1 W3oHzBNxNHQYd2EudhAbG78uzCbfktqUc9u9NOISgjGmicFY/OyDv4stjOuHMSsyiP2k D4R+6UjJdEe2hK/XYK7hZ2EVgvMrx8FTX3KvXBCuYFBSQNRkLTUREVb/FoKqI3DVB3rp JRub84KQCjyQC4LOWbsXFQcisIPDmtPdmojW2CeTfbZViZrQfsMt5ocAzQ0ftj98KxfV d4+m/4CdL/19aHcgJprwopMuh1MXLEh4/bjjYz0lTirG5aj7lPj6VwVZeLVV7HVOPt+o B/vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715807815; x=1716412615; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=uO72t1z4PhC45RlSB4zxjIXXfxmOyzDDnn9KfpOoEe4=; b=J+4cgTAHiBMT3d2w6KMSgG+K7yv1aXPAoFZ65XZ+ZME3/If2jV0wmKE88gB5lO9Rdf wkURTDiTvTysuaf1rWTXU7H5+VbAjrZiM1/GjQgBgnf1pQ1jVEL9dxpxgyV7C/PHnMLi bJ+HMXNzcEdc+zEUgBbSEvkXx1XatFm7NiZ0+9vt5xKq4L6ThAlks4H/I7/B2T5Cp4n5 4qqon0gcA42Y6DRFrL1gE38XwcL+RdQpCkqXCwNJ9R67F3BwMaLkDhh0/7o0YRFx4jQ+ Ry6AvEh1IgsVe5KNd+Yqby15DP7qrUoOmNsec4kTH7nDn9zSzFeBnRDY0JsSuOO3imFg hJ5w== X-Forwarded-Encrypted: i=1; AJvYcCXRwXgWo7Mbb5ZPT7XwKULJr10NTbfqz95wc91UFr753ob9hey9n5TlugeKFPds+Cc/+kmPmuod6vY0Vm0XSfHeVpX1RfM5mlwDUg== X-Gm-Message-State: AOJu0YyRCHEATNfgjnNM7X9Zy9GfZuVQYehexC7h5H1UAEVqalfm1iHT Y/4C7Z82BTHiErx4sli6fN4oh0I/Wavskc1CMqFN44XMsvLGwMqQr35N7R96aWw= X-Google-Smtp-Source: AGHT+IEUctWvzTXBDh1cypHW7Zi5V2fUkv/hXY0KH6Mc4+fNR34ZBg14Lrsy8sjgxwL6kcVno6FY0A== X-Received: by 2002:a05:6000:1968:b0:34d:707c:922a with SMTP id ffacd0b85a97d-3504a6310bbmr16846290f8f.13.1715807815272; Wed, 15 May 2024 14:16:55 -0700 (PDT) Received: from [10.1.2.176] ([149.14.240.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-41fccce25casm244577145e9.20.2024.05.15.14.16.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 May 2024 14:16:54 -0700 (PDT) Message-ID: <721b4837-420f-4acf-95b4-514395ed8896@linaro.org> Date: Wed, 15 May 2024 23:16:52 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v3 4/6] drm/panel: simple: Add Lincoln Tech Sol LCD185-101CT panel To: Aradhya Bhatia , Jessica Zhang , Sam Ravnborg , David Airlie , Daniel Vetter , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liu Ying , Thierry Reding , Maarten Lankhorst , Tomi Valkeinen , Laurent Pinchart Cc: DRI Development List , Devicetree List , Linux Kernel List , Nishanth Menon , Vignesh Raghavendra , Praneeth Bajjuri , Udit Kumar , Devarsh Thakkar , Jai Luthra References: <20240515095133.745492-1-a-bhatia1@ti.com> <20240515095133.745492-5-a-bhatia1@ti.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20240515095133.745492-5-a-bhatia1@ti.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/05/2024 11:51, Aradhya Bhatia wrote: > Add support for Lincoln Technology Solutions LCD185-101CT, 10.1", > 1920x1200, 8-bit TFT LCD with LVDS interface, LED backlight and PCAP > touch support (Goodix GT928). > > [0]: Panel Datasheet > https://lincolntechsolutions.com/wp-content/uploads/2023/04/LCD185-101CTL1ARNTT_DS_R1.3.pdf > > Signed-off-by: Aradhya Bhatia > --- > drivers/gpu/drm/panel/panel-simple.c | 32 ++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index dcb6d0b6ced0..10e974bffd28 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2870,6 +2870,35 @@ static const struct panel_desc lg_lb070wv8 = { > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > +static const struct drm_display_mode lincolntech_lcd185_101ct_mode = { > + .clock = 155127, > + .hdisplay = 1920, > + .hsync_start = 1920 + 128, > + .hsync_end = 1920 + 128 + 20, > + .htotal = 1920 + 128 + 20 + 12, > + .vdisplay = 1200, > + .vsync_start = 1200 + 19, > + .vsync_end = 1200 + 19 + 4, > + .vtotal = 1200 + 19 + 4 + 20, > +}; > + > +static const struct panel_desc lincolntech_lcd185_101ct = { > + .modes = &lincolntech_lcd185_101ct_mode, > + .bpc = 8, > + .num_modes = 1, > + .size = { > + .width = 217, > + .height = 136, > + }, > + .delay = { > + .prepare = 50, > + .disable = 50, > + }, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, > + .connector_type = DRM_MODE_CONNECTOR_LVDS, > +}; > + > static const struct display_timing logictechno_lt161010_2nh_timing = { > .pixelclock = { 26400000, 33300000, 46800000 }, > .hactive = { 800, 800, 800 }, > @@ -4644,6 +4673,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "lg,lb070wv8", > .data = &lg_lb070wv8, > + }, { > + .compatible = "lincolntech,lcd185-101ct", > + .data = &lincolntech_lcd185_101ct, > }, { > .compatible = "logicpd,type28", > .data = &logicpd_type_28, Reviewed-by: Neil Armstrong