From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 11/11] dmaengine: cppi41: Fix teardown warnings Date: Mon, 9 Jan 2017 21:46:51 +0300 Message-ID: <72228045-8c2d-3ea4-3fbb-00477b47a80b@cogentembedded.com> References: <20170109160656.3470-1-abailon@baylibre.com> <20170109160656.3470-12-abailon@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170109160656.3470-12-abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexandre Bailon , vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Cc: dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, ptitiano-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, b-liu-l0cyMroinI0@public.gmane.org List-Id: devicetree@vger.kernel.org On 01/09/2017 07:06 PM, Alexandre Bailon wrote: > During the teardown of a RX channel, because there is only one > completion queue available for RX channel, descriptor of another > channel may be popped which will cause 2 warnings: > - the first one because we popped a wrong descriptor > (neither the channel's descriptor, neither the teardown descriptor). Neither ... nor. > - the second one happen during the teardown of another channel, > because we can't find the channel descriptor > (that is, the one that caused the first warning). > Use the teardown queue as completion queue during the teardown. Hm, what's a teardown queue? I don't remember this documented... memory fade is always possible tho... :-) > Note that fix doesn't fix all the teardown warnings: > I still get some when I run some corner case. > > Signed-off-by: Alexandre Bailon [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html