From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88B4431355D; Wed, 4 Mar 2026 11:30:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772623802; cv=none; b=kKCnc8Yf+4XY+ZEeIbMdAOvjsBWSugUD5VvmB7RDYrE8pm0AaWIHCw+4i7zvpiGpOxoUBEyLuoyor2mUwjk0MCoaU/3j1p/pDQPoy9t58zTowEyrASrVbTO+6D7de7MTWSmATS6txvw0KZEytGq6UiYqPUCjZRybkDwhuVPbf/c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772623802; c=relaxed/simple; bh=ce1rLtFvspwXUakaoa4epIqD4bjKPfqdMKeXR64COss=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Dj6wpCjUDKozAQvFLDVIeNO6dGv1XIFRheU1zgQCewmvzVVEnTKfkOW+i6g9Sss2DmupEd3pmhMQm1KllqXSjz0tPFJEJ3QTrQeW7B2c0OPN85FhUid9OdE/LDoC4AKA0+ZtDjRABp2JuWhyQlRx2G62oF4sMZSgp6nDFWv+5AQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AdaCXu/x; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AdaCXu/x" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 519DAC19423; Wed, 4 Mar 2026 11:29:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772623802; bh=ce1rLtFvspwXUakaoa4epIqD4bjKPfqdMKeXR64COss=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AdaCXu/xaDDIqOuB9xhOhJ8pMoSlm8iDbWgUTGGw1ELQxpM2B7mkEFpy/lqhcdOQv LZp4ftQVQOaujoLSwncZpSM781BsYq0VXvUqcFMmMLrQ+HqaDjGVi942WRWHWg2xK6 gjpgwuWkMAJvPlPmaf27zn8agjEi0PbEmLU+DmKIon6Ea4jnipF8CJY2X629DorI2c WRCFqd8+Fnn68zcS6FKW2L5PsW4rxzr3Sg9pNYcwyFQPaG+4UB5mvRy621ONbev00n +zo4hXw0hGGKNrN/2WwPwdUK9cbv+L8VBqgwsu+FVkhazWMGMQ62fY8kCYSf2uZ3Rj 5sBaeRibwLl5Q== Message-ID: <7239b66d-be59-45f2-be8a-78d3803d345b@kernel.org> Date: Wed, 4 Mar 2026 12:29:57 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/6] dt-bindings: sram: Describe the IMEM present in Qualcomm IPQ SoCs To: Kathiravan Thirumoorthy , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260228-imem-v3-0-20fbcc1a9404@oss.qualcomm.com> <20260228-imem-v3-1-20fbcc1a9404@oss.qualcomm.com> <20260301-secret-exotic-nightingale-80f55c@quoll> <4cf9c98e-767c-44d3-9e71-bcc790e83997@oss.qualcomm.com> <6606bdbc-95b0-4adc-92e5-cad70d250cee@kernel.org> <33737c4f-b668-418c-ab03-f27ed3b6fcff@oss.qualcomm.com> <78d08114-d573-42be-9cff-39c228c68848@oss.qualcomm.com> <0be1b15f-df0a-4ff0-ac97-8aaa46dd9b7c@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <0be1b15f-df0a-4ff0-ac97-8aaa46dd9b7c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 04/03/2026 12:16, Kathiravan Thirumoorthy wrote: > > On 3/3/2026 4:18 PM, Konrad Dybcio wrote: >> On 3/2/26 5:33 PM, Krzysztof Kozlowski wrote: >>> On 02/03/2026 15:56, Konrad Dybcio wrote: >>>> On 3/2/26 3:54 PM, Krzysztof Kozlowski wrote: >>>>> On 02/03/2026 15:10, Konrad Dybcio wrote: >>>>>>> Also not accurate - "sram" is not the reboot reason, which has node name >>>>>>> called "reboot-mode". >>>>>> What I was referring to is: >>>>>> >>>>>> patternProperties: >>>>>> "^([a-z0-9]*-)?sram(-section)?@[a-f0-9]+$": >>>>>> >>>>>> where the 'sram' (not 'smem' as I typo'd above) is obligatory >>>>> I know and sram is not part of "reboot-mode" name. It is "reboot-mode" >>>>> in existing binding and DTS, not "reboot-mode-sram". >>>> In any case, I believe it'd be good to drop that requirement >>> Ah, and one more thing, the syscon-reboot-mode is Linux driver with its >>> own Linux requirements - syscon - so probably not working with sram >>> bindings. That's another reason full binding should be posted and tested >>> - I speculate it simply does not work. >> It won't even probe, we talked about that a long time ago on a similar >> occasion >> >> https://lore.kernel.org/linux-arm-msm/f6b16d1d-3730-46d1-81aa-bfaf09c20754@oss.qualcomm.com/ > > > Sorry, TBH, I'm confused here... > > I agree that, DT node should be as simple as below for now until the > child node is added. > > sram@8600000 { >    compatible = "qcom,ipq5332-imem", "mmio-sram"; >    reg = <0x08600000 0x14000>; >    no-memory-wc; > }; > > When I add the child node, it will eventually become like > > sram@8600000 { >         compatible = "qcom,ipq5332-imem", "mmio-sram"; >         reg = <0 0x08600000 0 0x1c000>; >         ranges = <0 0 0x08600000 0x1c000>; > >         no-memory-wc; > >         #address-cells = <1>; >         #size-cells = <1>; > >         restart_reason: restartreason-sram@7b0 { >                 reg = <0x7b0 0x4>; >         }; > }; > > which seems to be matching with the binding requirements. > > and the consumer can reference to this node like > > sram = <&restart_reason>; > > I'm not following what's being suggested here. Can you please help me to > understand further on this. I already asked you what to do. "Nope, sorry. Bindings must be posted complete, see writing-bindings." So post it after testing. We suggest that it simply does not work, but you can always prove us wrong. Best regards, Krzysztof