From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: forbidden405@outlook.com, Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v7 9/9] net: hisi_femac: remove unused MODULE_ALIAS()
Date: Fri, 1 Mar 2024 07:50:35 +0100 [thread overview]
Message-ID: <724c1d96-6ec6-49c9-9714-502abd741252@linaro.org> (raw)
In-Reply-To: <20240301-net-v7-9-45823597d4d4@outlook.com>
On 01/03/2024 04:36, Yang Xiwen via B4 Relay wrote:
> From: Yang Xiwen <forbidden405@outlook.com>
>
> We already have MODULE_DEVICE_TABLE(), so this MODULE_ALIAS() has no use
> and should be removed.
>
That's not accurate. You don't have for platform IDs, so you basically
remove ability to autoload via platform. It's fine for me, but the
commit msg is just misleading.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-01 6:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 3:35 [PATCH net-next v7 0/9] net: hisi-femac: add support for Hi3798MV200, remove unmaintained compatibles Yang Xiwen via B4 Relay
2024-03-01 3:35 ` [PATCH net-next v7 1/9] dt-bindings: net: hisilicon-femac-mdio: convert to YAML Yang Xiwen via B4 Relay
2024-03-01 3:35 ` [PATCH net-next v7 2/9] dt-bindings: net: hisilicon,hisi-femac-mdio: remove clocks Yang Xiwen via B4 Relay
2024-03-01 3:35 ` [PATCH net-next v7 3/9] net: mdio: hisi-femac: remove clock Yang Xiwen via B4 Relay
2024-03-01 3:35 ` [PATCH net-next v7 4/9] dt-bindings: net: convert hisi-femac.txt to YAML Yang Xiwen via B4 Relay
2024-03-01 6:49 ` Krzysztof Kozlowski
2024-03-05 2:58 ` Yang Xiwen
2024-03-05 7:12 ` Krzysztof Kozlowski
2024-03-01 3:35 ` [PATCH net-next v7 5/9] dt-bindings: net: hisi-femac: add mandatory MDIO bus subnode Yang Xiwen via B4 Relay
2024-03-01 3:35 ` [PATCH net-next v7 6/9] dt-bindings: net: hisi-femac: add binding for Hi3798MV200 FEMAC core Yang Xiwen via B4 Relay
2024-03-01 3:36 ` [PATCH net-next v7 7/9] net: hisi_femac: remove unused compatible strings Yang Xiwen via B4 Relay
2024-03-01 6:48 ` Krzysztof Kozlowski
2024-03-01 6:49 ` Yang Xiwen
2024-03-01 3:36 ` [PATCH net-next v7 8/9] net: hisi_femac: add support for hisi_femac core on Hi3798MV200 Yang Xiwen via B4 Relay
2024-03-01 3:36 ` [PATCH net-next v7 9/9] net: hisi_femac: remove unused MODULE_ALIAS() Yang Xiwen via B4 Relay
2024-03-01 6:50 ` Krzysztof Kozlowski [this message]
2024-03-05 6:51 ` Yang Xiwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=724c1d96-6ec6-49c9-9714-502abd741252@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=forbidden405@outlook.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).