From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: Shawn Guo <shawnguo@kernel.org>, Frieder Schrempf <frieder@fris.de>
Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
stable@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH 4/8] arm64: dts: imx8mm-kontron: Fix reg_rst_eth2 and reg_vdd_5v regulators
Date: Tue, 5 Oct 2021 19:06:57 +0200 [thread overview]
Message-ID: <725cc24e-f264-60ea-e30c-c50a61f7fe88@kontron.de> (raw)
In-Reply-To: <20211005070949.GB20743@dragon>
On 05.10.21 09:09, Shawn Guo wrote:
> On Thu, Sep 30, 2021 at 05:56:27PM +0200, Frieder Schrempf wrote:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> The regulator reg_vdd_5v represents the fixed 5V supply on the board which
>> can't be switched off. Mark it as always-on.
>>
>> The regulator reg_rst_eth2 should keep the reset signal of the USB ethernet
>> adapter deassertet anytime. Fix the polarity and mark it as always-on.
>
> It seems to be wrong from the beginning that the reset is modelled by a
> regulator.
Right, but at least at the time when I upstreamed this, there was no way
to pass the reset GPIO to a USB device driver and using a regulator
seems to be an accepted workaround as far as I understand.
>
>>
>> Fixes: 21c4f45b335f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>> ---
>> arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
>> index 62ba3bd08a0c..f2c8ccefd1bf 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
>> @@ -70,7 +70,9 @@ reg_rst_eth2: regulator-rst-eth2 {
>> regulator-name = "rst-usb-eth2";
>> pinctrl-names = "default";
>> pinctrl-0 = <&pinctrl_usb_eth2>;
>> - gpio = <&gpio3 2 GPIO_ACTIVE_LOW>;
>> + gpio = <&gpio3 2 GPIO_ACTIVE_HIGH>;
>> + enable-active-high;
>> + regulator-always-on;
>> };
>>
>> reg_vdd_5v: regulator-5v {
>> @@ -78,6 +80,7 @@ reg_vdd_5v: regulator-5v {
>> regulator-name = "vdd-5v";
>> regulator-min-microvolt = <5000000>;
>> regulator-max-microvolt = <5000000>;
>> + regulator-always-on;
>
> You do not have any on/off control over the regulator. So how does this
> always-on property make any difference?
Right, this doesn't make a difference and is definitely not a fix, I
will drop it. Anyway, this regulator is just there for completeness of
the hardware description.
>
>> };
>> };
>>
>> --
>> 2.33.0
>>
next prev parent reply other threads:[~2021-10-05 17:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 15:56 [PATCH 0/8] Devicetree fixes and additions for Kontron SL/BL i.MX8MM boards Frieder Schrempf
2021-09-30 15:56 ` [PATCH 1/8] arm64: dts: imx8mm-kontron: Add support for ultra high speed modes on SD card Frieder Schrempf
2021-10-05 6:45 ` Shawn Guo
2021-10-15 10:44 ` Frieder Schrempf
2021-09-30 15:56 ` [PATCH 2/8] arm64: dts: imx8mm-kontron: Make sure SOC and DRAM supply voltages are correct Frieder Schrempf
2021-09-30 16:02 ` Frieder Schrempf
2021-10-05 6:49 ` Shawn Guo
2021-10-05 6:53 ` Shawn Guo
2021-10-05 13:10 ` Frieder Schrempf
2021-10-15 3:51 ` Shawn Guo
2021-09-30 15:56 ` [PATCH 3/8] arm64: dts: imx8mm-kontron: Set VDD_SNVS to 800 mV Frieder Schrempf
2021-10-05 6:56 ` Shawn Guo
2021-10-05 13:14 ` Frieder Schrempf
2021-10-15 4:04 ` Shawn Guo
2021-09-30 15:56 ` [PATCH 4/8] arm64: dts: imx8mm-kontron: Fix reg_rst_eth2 and reg_vdd_5v regulators Frieder Schrempf
2021-10-05 7:09 ` Shawn Guo
2021-10-05 17:06 ` Frieder Schrempf [this message]
2021-10-15 4:09 ` Shawn Guo
2021-10-15 11:32 ` Frieder Schrempf
2021-09-30 15:56 ` [PATCH 5/8] arm64: dts: imx8mm-kontron: Fix CAN SPI clock frequency Frieder Schrempf
2021-10-05 7:12 ` Shawn Guo
2021-10-05 17:17 ` Frieder Schrempf
2021-10-15 4:12 ` Shawn Guo
2021-09-30 15:56 ` [PATCH 6/8] arm64: dts: imx8mm-kontron: Fix connection type for VSC8531 RGMII PHY Frieder Schrempf
2021-10-05 7:20 ` Shawn Guo
2021-09-30 15:56 ` [PATCH 7/8] arm64: dts: imx8mm-kontron: Fix reset delays for ethernet PHY Frieder Schrempf
2021-09-30 15:56 ` [PATCH 8/8] arm64: dts: imx8mm-kontron: Leave reg_vdd_arm always powered on Frieder Schrempf
2021-09-30 18:52 ` Heiko Thiery
2021-10-05 7:27 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=725cc24e-f264-60ea-e30c-c50a61f7fe88@kontron.de \
--to=frieder.schrempf@kontron.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frieder@fris.de \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).